Release: Prerelease 8.5.0-alpha.6 #29633
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…js/storybook into docs_adjust_svelte_snippets_v5
…s_v5 Docs: Svelte CSF snippets
…lte_csf Docs: Minor fixes to Svelte CSF
CLI: Fix qwik init
github-actions
bot
added
the
release
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
113 file(s) reviewed, 56 comment(s)
Edit PR Review Bot Settings | Greptile
| //👇 Imports the Button stories | ||
| import * as ButtonStories from './Button.stories.svelte'; |
There was a problem hiding this comment.
style: Import path should match the CSF version for consistency
|
|
||
| <Story name="Text"> <Button text="Hello" on:click={action('clicked')}/> </Story> | ||
| ``` | ||
|
|
||
| ```ts filename="Button.stories.ts" renderer="svelte" language="ts-4-9" |
There was a problem hiding this comment.
style: The Svelte example uses 'Primary' as story name while other frameworks use 'Text' or 'Basic'. Consider standardizing the story name for consistency.
| @@ -30,6 +62,42 @@ export default { | |||
| }; | |||
| ``` | |||
|
|
|||
| ```svelte filename="Button.stories.svelte" renderer="svelte" language="ts-4-9" tabTitle="Svelte CSF" | |||
There was a problem hiding this comment.
style: This example is identical to the JavaScript version above. Consider removing one of the duplicates to avoid confusion.
| {/* prettier-ignore-start */ } | ||
|
|
There was a problem hiding this comment.
syntax: Extra space after 'start' in prettier-ignore comment
docs/versions/next.json
Outdated
| @@ -1 +1 @@ | |||
| {"version":"8.5.0-alpha.5","info":{"plain":"- Addon Test: Only optimize react deps if applicable in vitest-plugin - [#29617](https://github.com/storybookjs/storybook/pull/29617), thanks @yannbf!\n- Addon Test: Optimize internal dependencies - [#29595](https://github.com/storybookjs/storybook/pull/29595), thanks @yannbf!\n- CLI: Fix init help for `storybook` command - [#29480](https://github.com/storybookjs/storybook/pull/29480), thanks @toothlessdev!\n- Composition: Fix composed story search - [#29453](https://github.com/storybookjs/storybook/pull/29453), thanks @jsingh0026!"}} | |||
| {"version":"8.5.0-alpha.6","info":{"plain":"- CLI: Fix qwik init - [#29632](https://github.com/storybookjs/storybook/pull/29632), thanks @shilman!"}} | |||
React Native Web: Add framework, CLI integration, sandboxes
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.5
branch
from
5cd190d to
300192c
Compare
shilman
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 300192c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 0 | 109 | 🚨 +109 🚨 |
| Self size | 0 B | 37 KB | 🚨 +37 KB 🚨 |
| Dependency size | 0 B | 18.69 MB | 🚨 +18.69 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
This is an automated pull request that bumps the version from
8.5.0-alpha.5to8.5.0-alpha.6.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.6.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.6