Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Upgrade @types/estree package to version v1.0.6 #29477

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

hakshu25
Copy link
Contributor

@hakshu25 hakshu25 commented Oct 29, 2024

Closes #29443

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.2 MB 78.2 MB 0 B 1.11 0%
initSize 143 MB 143 MB -16.4 kB 1.02 0%
diffSize 65.1 MB 65.1 MB -16.4 kB -1.48 0%
buildSize 6.88 MB 6.87 MB -1.33 kB -1.17 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.9 MB 1.9 MB -1.06 kB -1.28 -0.1%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.88 MB 3.88 MB -1.06 kB -1.28 0%
buildPreviewSize 3 MB 3 MB -271 B -0.79 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 23.1s 6.9s -16s -165ms -0.98 -231%
generateTime 19.6s 19.8s 178ms -0.78 0.9%
initTime 14.2s 13.6s -580ms -1.11 -4.2%
buildTime 8.8s 7.4s -1s -426ms -1.7 🔰-19.2%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.3s 6.3s 990ms 0.22 15.7%
devManagerResponsive 3.2s 3.6s 386ms -0.4 10.5%
devManagerHeaderVisible 536ms 595ms 59ms -0.2 9.9%
devManagerIndexVisible 568ms 679ms 111ms 0.04 16.3%
devStoryVisibleUncached 960ms 1s 96ms -0.07 9.1%
devStoryVisible 567ms 677ms 110ms 0.1 16.2%
devAutodocsVisible 464ms 538ms 74ms -0.13 13.8%
devMDXVisible 470ms 528ms 58ms -0.1 11%
buildManagerHeaderVisible 490ms 575ms 85ms -0.18 14.8%
buildManagerIndexVisible 503ms 580ms 77ms -0.27 13.3%
buildStoryVisible 492ms 574ms 82ms -0.19 14.3%
buildAutodocsVisible 414ms 459ms 45ms -0.28 9.8%
buildMDXVisible 437ms 503ms 66ms 0.29 13.1%

Greptile Summary

Updates the @types/estree package from v0.0.51 to v1.0.6 in the React renderer to resolve type conflicts with rollup's type definitions.

  • Updated @types/estree to v1.0.6 in /code/renderers/react/package.json to align with rollup's type dependencies
  • Resolves type conflict where "BaseNode" was not properly exported from @types/estree
  • Fixes build errors in projects using both Storybook React and rollup type definitions

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Oct 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f103a0a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes added maintenance User-facing maintenance tasks ci:normal labels Nov 4, 2024
@jonniebigodes jonniebigodes added dependencies and removed maintenance User-facing maintenance tasks labels Nov 4, 2024
@yannbf
Copy link
Member

yannbf commented Dec 3, 2024

Hey @hakshu25 thanks a lot for your contribution! Given the difference in version, I'm assuming this is a breaking change. Can you clarify the effects of this and whether this is a change that should not affect any user on previous versions of Storybook (or that have different versions of @types/node installed)? We should determine whether this is a Storybook 8.5 or Storybook 9.0 kind of thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/react - @types/estree is outdated
3 participants