Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Use canceled instead of cancelled #29438

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 24, 2024

Use canceled for consistency across the codebase.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 181 B -3 0%
initSize 146 MB 146 MB 86.8 kB -2.66 0.1%
diffSize 68.4 MB 68.5 MB 86.6 kB 5.13 0.1%
buildSize 7.1 MB 7.1 MB 0 B 4.29 0%
buildSbAddonsSize 1.79 MB 1.79 MB 0 B 0.96 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.85 MB 1.85 MB 0 B 3.96 0%
buildSbPreviewSize 271 kB 271 kB 0 B -1.11 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.1 MB 4.1 MB 0 B 4.26 0%
buildPreviewSize 3 MB 3 MB 0 B 0.73 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 13.4s 17s 3.5s 0.49 20.9%
generateTime 23.2s 25.4s 2.1s 0.83 8.4%
initTime 14.9s 16.4s 1.4s 0.45 9%
buildTime 12.3s 9.4s -2s -907ms -0.09 -30.6%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 8.2s 7.3s -847ms 1.16 -11.5%
devManagerResponsive 5.2s 4.9s -297ms 1.6 🔰-6%
devManagerHeaderVisible 705ms 691ms -14ms 0.58 -2%
devManagerIndexVisible 757ms 751ms -6ms 0.75 -0.8%
devStoryVisibleUncached 1.7s 1.2s -553ms 0.7 -44.7%
devStoryVisible 757ms 720ms -37ms 0.48 -5.1%
devAutodocsVisible 694ms 595ms -99ms 0.23 -16.6%
devMDXVisible 579ms 648ms 69ms 1.07 10.6%
buildManagerHeaderVisible 1.1s 708ms -410ms 0.44 -57.9%
buildManagerIndexVisible 1.1s 727ms -438ms 0.32 -60.2%
buildStoryVisible 1s 707ms -368ms 0.14 -52.1%
buildAutodocsVisible 820ms 581ms -239ms 0.21 -41.1%
buildMDXVisible 777ms 624ms -153ms 0.7 -24.5%

Greptile Summary

This pull request standardizes the spelling of "canceled" across the Storybook codebase, replacing instances of "cancelled" for consistency.

  • Changed "cancelled" to "canceled" in code/addons/test/src/node/reporter.ts
  • Updated TestingModuleProgressReportPayload type in code/core/src/core-events/data/testing-module.ts
  • Modified experimental_serverChannel function in code/core/src/core-server/presets/common-preset.ts
  • Updated log messages in code/lib/cli-storybook/src/sandbox.ts
  • Adjusted error messages in scripts/task.ts and scripts/utils/options.ts

@shilman shilman added cleanup Minor cleanup style change that won't show up in release changelog ci:normal labels Oct 24, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Oct 24, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8224347. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Base automatically changed from unified-ui-testing to next October 24, 2024 09:18
@shilman shilman self-assigned this Oct 28, 2024
@youneshenniwrites
Copy link

@shilman, it seems a few instances of the British spelling cancelled were missed. A global search shows additional places needing correction to the American spelling canceled.

Screenshot 2024-12-12 at 14 05 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants