Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide tool bar on docs page #22133

Closed

Conversation

jatinparmar96
Copy link

Closes #22081

What I did

Add a check so the toolbar is not shown on the docs page

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access the docs page of any story

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf
Copy link
Member

yannbf commented Apr 18, 2023

Hey there! Thanks for your contribution :)

Seems like this change is a little too drastic though. It disables the toolbar for any docs page. I believe the issue you're referring to mentions to disable the toolbar only in "unattached" docs, which is when there are no actual stories. Still, community addons do all sorts of things, so I'd assume users might want to be able to toggle the toolbar.

Thoughts @MichaelArestad @cdedreuille ?

@jatinparmar96
Copy link
Author

Ah I see, sorry I think I got confused about that, I will update the PR @yannbf

@cdedreuille cdedreuille self-assigned this Apr 24, 2023
@cdedreuille cdedreuille requested review from yannbf and JReinhold April 24, 2023 14:29
@JReinhold
Copy link
Contributor

Thanks for the PR @jatinparmar96. As @yannbf suggest, we don't want to always hide toolbar. Something like this comment suggests would be more valuable. #22081 (comment)

@JReinhold JReinhold closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add option to hide toolbars for doc pages
4 participants