bugfix #135 handle draining messages after unsubscribe #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clients use
auto ack
andunsubscribe
it's possible that messages are considered as processed, while they have never been forwarded byread
.In order to avoid accidental message los a DrainingConsumer state was added, that comes together with the
DrainingMessageException
.Access to
Parser
internal buffer has been simplified, by addingisBufferEmpty
.Same applies for
Client
hereisBufferEmpty
andflushBufferedFrames
were added.