ACM-16425-add-negative-label-filtering-to-Discovered-policies-table

[jeswanke]

Signed-off-by: John Swanke [email protected]

[jeswanke]

/test unit-tests-sonarcloud

[jeswanke]

/test unit-tests-sonarcloud

[KevinFCormier]

Hey John,

Overall, the code looks good and it works well. I just found a couple issues:

1. If I add a new policy with the discovered policies page open, when the search query next executes, the page crashes.
2. Terminology question - can isNegatable only be used for a label? Are all labels negatable? The equalsLabel function seems to deem the two concepts equivalent, so I think either that function or the flag should be renamed.

[jeswanke]

ok, this version:

1. fixes that crash bug
2. fixes a filtering bug handling all permutations of != and = with same filters
   if any filters are !=, will only show those items (new)
   if any filters are =, will only show items that match (as before)
   if an item has both, != overrules =
3. changes equalsLabel to matchesFilterValue
   4 changes isNegatable to supportsInequality -- which is the kube term
   we could actually use this with other filters such as !=System in application list to show all apps that aren't system

[sonarqubecloud]

Quality Gate passed

Issues
7 New issues
3 Accepted issues

Measures
0 Security Hotspots
81.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[KevinFCormier]

/hold

[KevinFCormier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke, KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KevinFCormier,jeswanke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KevinFCormier]

/override "Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213"

[openshift-ci]

@KevinFCormier: Overrode contexts on behalf of KevinFCormier: Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213

In response to this:

/override "Red Hat Konflux / acm-213-enterprise-contract-registry-standard / console-acm-213"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[KevinFCormier]

/override "Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28"

[openshift-ci]

@KevinFCormier: Overrode contexts on behalf of KevinFCormier: Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28

In response to this:

/override "Red Hat Konflux / mce-28-enterprise-contract-registry-standard / console-mce-mce-28"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.