VM actions should use cluster-proxy Service instead of Route #4198
Conversation
Signed-off-by: zlayne <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zlayne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| // req.url is one of: /virtualmachines/<action> OR /virtualmachineinstances/<action> | ||
| // the VM name is needed between the kind and action for the correct api url. | ||
| const splitURL = req.url.split('/') | ||
| const joinedURL = `${splitURL[1]}/${body.vmName}/${splitURL[2]}` | ||
| const path = `${proxyServer}/${body.managedCluster}/apis/subresources.kubevirt.io/v1/namespaces/${body.vmNamespace}/${joinedURL}` | ||
| const proxyService = 'https://cluster-proxy-addon-user.multicluster-engine.svc.cluster.local:9092' |
There was a problem hiding this comment.
Namespace can be customized by customers, and should not be hardcoded. See https://github.com/stolostron/console/blob/main/backend/src/routes/aggregators/utils.ts#L100 for example.
The other parts of the service addressed being hardcoded is OK, as they won't change in a given released version.
|
@KevinFCormier I am actually receiving the error |
Signed-off-by: zlayne <[email protected]>
|
/test unit-tests-sonarcloud |
Signed-off-by: zlayne <[email protected]>
Signed-off-by: zlayne <[email protected]>
Signed-off-by: zlayne <[email protected]>
Signed-off-by: zlayne <[email protected]>
Signed-off-by: zlayne <[email protected]>
|
/test unit-tests-sonarcloud |
|
No description provided.