fix defaultThemeMap: add accentColor to default to support colors #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you remove all the auto formatting changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I don't know if that's an issue or a possible feature, but I will consider an issue.
Recently I used
accentColorin my theme, to customize a native checkbox and Stitches don't apply the color in final CSS, so I addedaccentColorindefaultThemeMapto property support theme colors and it works.I used MDN Web Docs syntax and description to doc.
✅ Works
❌ Failure
Sandbox to Test
I hope it can be fixed, Thanks!