Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My attempt to get anonymous access working #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brandonmcclure
Copy link

Got anonymous access working. Updated readme explaining that you need to omit the normal USER variables to setup the anonymous user

… to omit the normal *_USER_* variables to setup the anonymous user
@brandonmcclure brandonmcclure changed the title My attempt to get anonymour access working My attempt to get anonymous access working Dec 23, 2020
@stilliard stilliard self-requested a review February 11, 2021 11:54
@stilliard
Copy link
Owner

Hey @brandonmcclure
Really sorry I missed this PR!

It looks fantastic, awesome work!

I think the only thing I think we should change before we can merge is instead of just omitting the existing env vars to assume anon access, we should instead have a dedicated FTP_ANONYMOUS_ACCESS=1 or something like that.
This way people have to purposeful opt into it as I use this container without the auto FTP env var based uses all the time too and wouldn't want this auto enabled.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants