Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeze search bar in documentation pane #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gmarraro
Copy link
Contributor

No description provided.

@gmarraro gmarraro requested a review from madduccino October 17, 2017 19:15
@gmarraro
Copy link
Contributor Author

I'm having trouble with the search bar div laying on top of the div underneath it. I'm trying to get it to sit on top of the other blocks.

@stevekrouse
Copy link
Owner

[This is an automated integration to preview this pull request's changes to the website.]

https://cdn.rawgit.com/stevekrouse/WoofJS/eac911d12b7d1274f9185a1f6b9af1648796982b/index.html

@madduccino
Copy link
Collaborator

madduccino commented Oct 18, 2017

You should be able to get what you want by adding a top margin to the div that wraps around everything that is equal to the height of the search bar, then adding a negative margin of the same value to the search bar.

Also, when you click on a block, the search field looks a little long on the right. Maybe play with the widths of the back button and the search field. (I'd use percentages)

@stevekrouse
Copy link
Owner

Thanks for the advice @madduccino!

@gmarraro thanks for starting to work on this one!

I feel like the ultimate solution here will be copying Scratch's design for the blocks menu, which will be a potentially more involved redesign #413. Let me know if you need more clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants