Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pycln #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add pycln #611

wants to merge 1 commit into from

Conversation

Quitlox
Copy link

@Quitlox Quitlox commented Dec 29, 2024

No description provided.

feat: add pycln
@github-actions github-actions bot requested a review from stevearc December 29, 2024 16:58
command = "pycln",
args = {
"--silence",
"-a",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs the default behavior tries to avoid removing imports that could have side effects, and providing this -a will remove even those imports. I think that for a default configuration it makes more sense to omit the -a. I like the defaults to avoid potentially logic-changing formats, and it's easier to add the -a back in your own config using prepend_args than it is to remove -a from the list of arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants