Skip to content

Use Spotless

Use Spotless #396

Triggered via pull request August 30, 2023 07:42
Status Failure
Total duration 1m 12s
Artifacts 1

review.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java#L101
[checkstyle] reported by reviewdog 🐶 Line is longer than 120 characters (found 122). Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java:101:0: error: Line is longer than 120 characters (found 122). (com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java#L32
[checkstyle] reported by reviewdog 🐶 '{' is not followed by whitespace. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java:32:31: error: '{' is not followed by whitespace. (com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java#L32
[checkstyle] reported by reviewdog 🐶 '}' is not preceded with whitespace. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java:32:32: error: '}' is not preceded with whitespace. (com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/EnumProcessor.java#L34
[checkstyle] reported by reviewdog 🐶 '{' is not followed by whitespace. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/EnumProcessor.java:34:29: error: '{' is not followed by whitespace. (com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/EnumProcessor.java#L34
[checkstyle] reported by reviewdog 🐶 '}' is not preceded with whitespace. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/EnumProcessor.java:34:30: error: '}' is not preceded with whitespace. (com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/ws/ErrorFactory.java#L32
[checkstyle] reported by reviewdog 🐶 '{' is not followed by whitespace. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/ws/ErrorFactory.java:32:28: error: '{' is not followed by whitespace. (com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/ws/ErrorFactory.java#L32
[checkstyle] reported by reviewdog 🐶 '}' is not preceded with whitespace. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/ws/ErrorFactory.java:32:29: error: '}' is not preceded with whitespace. (com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/task/SetChargingProfileTask.java#L107
[checkstyle] reported by reviewdog 🐶 Avoid inline conditionals. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/task/SetChargingProfileTask.java:107:41: error: Avoid inline conditionals. (com.puppycrawl.tools.checkstyle.checks.coding.AvoidInlineConditionalsCheck)
checkstyle: src/main/java/de/rwth/idsg/steve/ocpp/task/RemoteStartTransactionTask.java#L58
[checkstyle] reported by reviewdog 🐶 Comment matches to-do format 'TODO:'. Raw Output: /github/workspace/./src/main/java/de/rwth/idsg/steve/ocpp/task/RemoteStartTransactionTask.java:58:7: error: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)
checkstyle
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
Do not hard code the IP address : src/main/java/de/rwth/idsg/steve/JettyServer.java#L222
Application with hard-coded IP addresses can become impossible to deploy in some cases. Externalizing IP adresses is preferable. AvoidUsingHardCodedIP (Priority: 3, Ruleset: Best Practices) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_bestpractices.html#avoidusinghardcodedip
Avoid empty catch blocks: src/main/java/de/rwth/idsg/steve/JettyServer.java#L254
Empty Catch Block finds instances where an exception is caught, but nothing is done. In most circumstances, this swallows an exception which should either be acted on or reported. EmptyCatchBlock (Priority: 3, Ruleset: Error Prone) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_errorprone.html#emptycatchblock
Avoid empty catch blocks: src/main/java/de/rwth/idsg/steve/JettyServer.java#L262
Empty Catch Block finds instances where an exception is caught, but nothing is done. In most circumstances, this swallows an exception which should either be acted on or reported. EmptyCatchBlock (Priority: 3, Ruleset: Error Prone) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_errorprone.html#emptycatchblock
Do not hard code the IP address : src/main/java/de/rwth/idsg/steve/JettyServer.java#L268
Application with hard-coded IP addresses can become impossible to deploy in some cases. Externalizing IP adresses is preferable. AvoidUsingHardCodedIP (Priority: 3, Ruleset: Best Practices) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_bestpractices.html#avoidusinghardcodedip
Avoid empty catch blocks: src/main/java/de/rwth/idsg/steve/JettyServer.java#L270
Empty Catch Block finds instances where an exception is caught, but nothing is done. In most circumstances, this swallows an exception which should either be acted on or reported. EmptyCatchBlock (Priority: 3, Ruleset: Error Prone) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_errorprone.html#emptycatchblock
Useless parentheses.: src/main/java/de/rwth/idsg/steve/JettyServer.java#L282
Useless parentheses should be removed. UselessParentheses (Priority: 4, Ruleset: Code Style) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_codestyle.html#uselessparentheses
Avoid empty catch blocks: src/main/java/de/rwth/idsg/steve/JettyServer.java#L288
Empty Catch Block finds instances where an exception is caught, but nothing is done. In most circumstances, this swallows an exception which should either be acted on or reported. EmptyCatchBlock (Priority: 3, Ruleset: Error Prone) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_errorprone.html#emptycatchblock
Do not hard code the IP address : src/main/java/de/rwth/idsg/steve/JettyServer.java#L292
Application with hard-coded IP addresses can become impossible to deploy in some cases. Externalizing IP adresses is preferable. AvoidUsingHardCodedIP (Priority: 3, Ruleset: Best Practices) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_bestpractices.html#avoidusinghardcodedip
Unused import 'org.springframework.format.support.FormattingConversionService': src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java#L47
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_codestyle.html#unnecessaryimport
Unused import 'org.springframework.web.accept.ContentNegotiationManager': src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java#L52
Reports import statements that can be removed. They are either unused, duplicated, or the members they import are already implicitly in scope, because they're in java.lang, or the current package. UnnecessaryImport (Priority: 4, Ruleset: Code Style) https://pmd.github.io/pmd-6.49.0/pmd_rules_java_codestyle.html#unnecessaryimport

Artifacts

Produced during runtime
Name Size
PMD Report Expired
32.2 KB