Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip list starting from protocol 22 #4470

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Sep 18, 2024

Description

Fix the skip list. The values will still be incorrect until the ledger hash propagates within a month after the protocol vote. The docs and the XDR comments should be updated as well if we decide to accept this protocol change.

This PR is also meant to be a discussion on if we should care about fixing the skip list or not.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

graydon
graydon previously approved these changes Sep 19, 2024
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is all that's required, then I think we should absolutely do it! Though I am mildly concerned that we're somehow missing something and will wind up shipping another broken version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants