Make sorobaninfo basic more consistent with underlying network settings #4216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default output of
sorobaninfo
(aka "basic") uses custom names that don't correspond to what is xdr (making it hard to know which setting is what, and also creates a maintenance burden) and is also missing information on ledger fee related settings.This PR aims to simplify code and address both issues.
Old output:
New:
It's a bit annoying that our default json marshaller does not use strings for enum values (unlike when using
xdrpp/printer.h
but that one is not json compliant), but as fields are already unique it does not seem to be much of a problem.I think supercluster needs to be updated if we decide to merge this.