Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce trusted catchup #3615

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enforce trusted catchup #3615

wants to merge 2 commits into from

Conversation

marta-lokhova
Copy link
Contributor

Resolves #3503

@marta-lokhova marta-lokhova marked this pull request as ready for review November 30, 2022 23:10
@MonsieurNicolas MonsieurNicolas mentioned this pull request Dec 21, 2022
Open
@MonsieurNicolas
Copy link
Contributor

waiting to hear from the Horizon team before we can merge this

@marta-lokhova
Copy link
Contributor Author

pushed a minor change to not require trusted hash when catching up to current and log a warning that this is unsafe.

@mbsdf mbsdf self-requested a review January 23, 2023 23:49
@MonsieurNicolas
Copy link
Contributor

I noticed warnings in supercluster, so we'll have to make sure that all systems are updated before we can merge this

@mbsdf
Copy link

mbsdf commented Apr 17, 2023

relevant issue for reference: #3615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbsdf mbsdf mbsdf approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit and make commands "secure by default" - add "force" options when bypassing safety
3 participants
@marta-lokhova @MonsieurNicolas @mbsdf