Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blas/base/igamax #2171

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

aman-095
Copy link
Contributor

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to find the index of the first element having maximum absolute value as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/igamax is proposed.

Related Issues

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Apr 15, 2024
@aman-095
Copy link
Contributor Author

I explored and added the implementation for the generic routine of idamax. Once idamax and isamax are reviewed and merged, this can also be reviewed.

@kgryte
Copy link
Member

kgryte commented Apr 19, 2024

@aman-095 You'll want to update this PR to handle accessor arrays (see gcopy and gswap), which will include updating the implementation and adding associated tests. In order to handle complex number arrays, we'll need to implement dcabs1 and scabs1 (as in izamax and icamax).

@kgryte kgryte added status: Blocked Issue or pull request which is current blocked. Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Apr 19, 2024
@aman-095
Copy link
Contributor Author

Sure @kgryte I am currently working on cscal, and after this, I will start working on this as well. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. status: Blocked Issue or pull request which is current blocked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants