-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added message templating and corrected for Seq v2 #1
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contrib, and sorry for late reply! The way I usually test these is by creating a nuget package using "nuget pack Seq.App.HipChat.nuspec" in the project folder. Then I move the nupkg file to some folder and configure a repository in my local Seq instance. A NuGet feed doesn't need any fancy server software. Just go into Settings->Feeds in Seq and add a new feed pointing to a directory on your disk. Then it's just a matter of installing the app as if it where on nuget.org. |
var placeholders = data.Properties.ToDictionary(k => k.Key.ToLower(), v => v.Value); | ||
|
||
AddValueIfKeyDoesntExist(placeholders, "EventType", eventType); | ||
AddValueIfKeyDoesntExist(placeholders, "RenderedMessage", data.RenderedMessage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you set some custom properties here, but you never set "Level". Or am I missing something obvious?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, I've added it.
Will give it a while in the way you've suggested cheers
Have you tested this? Unfortunately not running HipChat anymore so I can't test personally. |
I've fixed the url for the latest build of Seq and have also added the ability to use custom placeholders in the message i.e. so you can include information from the error itself rather than just the message.
I've not worked out how I can test this on Seq itself so this will need testing/validation.