Cache client when it's fetched from first personalAccessClient

[danialhamod]

In my project I'm using createToken function from HasApiTokens trait and laravel-passport-memoized is used to avoid duplicated db queries caused by Passport.
But there still a duplicated query as the following:

Both queries are called by ClientRepository class's functions, first one is called by find and second by personalAccessClient.
Currently, personalAccessClient is not caching, so this pull request add an override to this function in order to cache the client when fetched.

[stayallive]

Have you tested these changes? Because looking over the code I am unsure this works as you describe.

If you have set the config option passport.personal_access_client.id it should already use ->find which is already memoized. Do you have that config setup or have you left that empty?

[danialhamod]

Have you tested these changes? Because looking over the code I am unsure this works as you describe.

If you have set the config option passport.personal_access_client.id it should already use ->find which is already memoized. Do you have that config setup or have you left that empty?

Sure I've tested code changes in my own project and it removes the query duplication.
Actually, setting the passport.personal_access_client.id resolved the problem in my case, thank you for reminding me of that.

[stayallive]

Interesting, I still wouldn't think this would remove the duplicate query... but maybe it's retrieved another way somewhere else. Anyway, give me some time to test this out and I'll merge it.

In the meantime explicitly setting the id of the personal access client in the config is a good workaround.

[danialhamod]

Interesting, I still wouldn't think this would remove the duplicate query... but maybe it's retrieved another way somewhere else. Anyway, give me some time to test this out and I'll merge it.

In the meantime explicitly setting the id of the personal access client in the config is a good workaround.

Don't worry, take your time.

When you're testing it plz consider the following:
Here is the function we are overriding in Passport (which calls the first query): personalAccessClient()

public function personalAccessClient()
{
    if ($this->personalAccessClientId) {
        return $this->find($this->personalAccessClientId);
    }

    $client = Passport::personalAccessClient();

    if (! $client->exists()) {
        throw new RuntimeException('Personal access client not found. Please create one.');
    }

    return $client->orderBy($client->getKeyName(), 'desc')->first()->client;
}

When config passport.personal_access_client.id isn't set, the $this->personalAccessClientId will be null so find won't be called (which means client will returned without being memoized) and this is the reason of query duplication.