feat(wallet)_: Show buy and receive CTAs on zero balance #21690

smohamedjavid · 2024-11-26T20:25:22Z

fixes #21683

Summary

This PR

adds wallet-card component
adds Buy and Receive CTAs above the assets list in the wallet home if the balance is zero

Buy.and.Receive.CTAs.mp4

Platforms

Android
iOS

Steps to test

Open Status
Create a new status profile
Verify the Buy and Receive CTAs are shown
Verify on tap of Buy, the Buy bottom sheet opens
Verify on tap of Receive, the shell share screen with default account QR opens

status: ready

status-im-auto · 2024-11-26T20:30:10Z

Jenkins Builds

Click to see older builds (16)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`3bf84b5`	#2	2024-11-26 20:30:09	~2 min	`tests`	📄`log`
✔️	`3bf84b5`	#2	2024-11-26 20:35:49	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`3bf84b5`	#2	2024-11-26 20:36:22	~8 min	`android`	🤖`apk` 📲
✔️	`3bf84b5`	#2	2024-11-26 20:36:38	~8 min	`ios`	📱`ipa` 📲

✔️	`47335c7`	#3	2024-11-26 20:43:20	~4 min	`tests`	📄`log`
✔️	`47335c7`	#3	2024-11-26 20:45:56	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`47335c7`	#3	2024-11-26 20:46:04	~7 min	`android`	🤖`apk` 📲
✔️	`47335c7`	#3	2024-11-26 20:47:42	~8 min	`ios`	📱`ipa` 📲

✔️	`ebdc715`	#4	2024-11-27 09:45:31	~4 min	`tests`	📄`log`
✔️	`ebdc715`	#4	2024-11-27 09:47:22	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ebdc715`	#4	2024-11-27 09:49:15	~8 min	`android`	🤖`apk` 📲
✔️	`ebdc715`	#4	2024-11-27 09:49:36	~8 min	`ios`	📱`ipa` 📲

✔️	`a2610e8`	#5	2024-11-28 09:32:53	~4 min	`tests`	📄`log`
✔️	`a2610e8`	#5	2024-11-28 09:35:43	~7 min	`android`	🤖`apk` 📲
✔️	`a2610e8`	#5	2024-11-28 09:36:34	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`a2610e8`	#5	2024-11-28 09:37:57	~9 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ad78329`	#6	2024-11-29 09:00:14	~4 min	`tests`	📄`log`
✔️	`ad78329`	#6	2024-11-29 09:02:13	~6 min	`android`	🤖`apk` 📲
✔️	`ad78329`	#6	2024-11-29 09:03:14	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ad78329`	#6	2024-11-29 09:04:12	~8 min	`ios`	📱`ipa` 📲

✔️	`b10a727`	#7	2024-11-29 18:28:30	~4 min	`tests`	📄`log`
✔️	`b10a727`	#7	2024-11-29 18:29:59	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b10a727`	#7	2024-11-29 18:30:37	~7 min	`android`	🤖`apk` 📲
✔️	`b10a727`	#7	2024-11-29 18:32:21	~8 min	`ios`	📱`ipa` 📲

src/quo/components/cards/wallet_card/view.cljs

shivekkhurana

Except for the schema location, everything else looks good

Thanks ))

shivekkhurana · 2024-11-28T03:45:17Z

The zero balance issues has a separate PR here: #21697

smohamedjavid · 2024-11-28T09:23:59Z

The zero balance issues has a separate PR here: #21697

Great! I will remove that fix from this PR

clauxx

Looks great!

status-im-auto · 2024-11-28T11:31:28Z

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 1
Passed tests: 7

IDs of expected to fail tests: 702843

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (7)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

shivekkhurana · 2024-11-29T07:42:22Z

@smohamedjavid

There are some changes to the copy:

shivekkhurana

The copy changed, I have added a screenshot and the figma file is also updated.

smohamedjavid · 2024-11-29T08:55:59Z

@shivekkhurana - Updated the copy and also the video in the PR description 🙏

status-im-auto · 2024-11-29T11:35:47Z

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 1
Passed tests: 6

IDs of failed tests: 727230

IDs of expected to fail tests: 702843

Failed tests (1)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
Device 2: `Text` is `0.12969 ETH`

critical/test_wallet.py:189: in test_wallet_send_asset_from_drawer
    self.errors.verify_no_errors()
base_test_case.py:192: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.3501 but expected to be 0.3502

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (6)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

pavloburykh · 2024-11-29T17:53:04Z

@smohamedjavid thanks for the PR. Ready for merge.

Signed-off-by: Mohamed Javid <[email protected]>

smohamedjavid self-assigned this Nov 26, 2024

smohamedjavid force-pushed the feat/cta-for-zero-balance branch from d0a3fd5 to 3bf84b5 Compare November 26, 2024 20:27

smohamedjavid force-pushed the feat/cta-for-zero-balance branch 2 times, most recently from 47335c7 to ebdc715 Compare November 27, 2024 09:40

smohamedjavid added the request-manual-qa label Nov 27, 2024

smohamedjavid requested review from alwx, shivekkhurana, briansztamfater, clauxx and mohsen-ghafouri November 27, 2024 09:45

smohamedjavid marked this pull request as ready for review November 27, 2024 09:45

shivekkhurana reviewed Nov 28, 2024

View reviewed changes

src/quo/components/cards/wallet_card/view.cljs Outdated Show resolved Hide resolved

shivekkhurana requested changes Nov 28, 2024

View reviewed changes

smohamedjavid force-pushed the feat/cta-for-zero-balance branch from ebdc715 to a2610e8 Compare November 28, 2024 09:28

smohamedjavid requested a review from shivekkhurana November 28, 2024 09:29

shivekkhurana approved these changes Nov 28, 2024

View reviewed changes

shivekkhurana added the wallet-core Issues for mobile wallet team label Nov 28, 2024

shivekkhurana added this to the 2.32.0 milestone Nov 28, 2024

clauxx approved these changes Nov 28, 2024

View reviewed changes

mohsen-ghafouri approved these changes Nov 28, 2024

View reviewed changes

briansztamfater approved these changes Nov 28, 2024

View reviewed changes

alwx approved these changes Nov 29, 2024

View reviewed changes

shivekkhurana self-requested a review November 29, 2024 08:19

shivekkhurana requested changes Nov 29, 2024

View reviewed changes

smohamedjavid force-pushed the feat/cta-for-zero-balance branch from a2610e8 to ad78329 Compare November 29, 2024 08:55

smohamedjavid requested a review from shivekkhurana November 29, 2024 08:56

shivekkhurana approved these changes Nov 29, 2024

View reviewed changes

pavloburykh self-assigned this Nov 29, 2024

feat(wallet)_: Show buy and receive cta on zero balance

b10a727

Signed-off-by: Mohamed Javid <[email protected]>

smohamedjavid force-pushed the feat/cta-for-zero-balance branch from ad78329 to b10a727 Compare November 29, 2024 18:23

smohamedjavid merged commit 52a8f8f into develop Nov 29, 2024
5 checks passed

smohamedjavid deleted the feat/cta-for-zero-balance branch November 29, 2024 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wallet)_: Show buy and receive CTAs on zero balance #21690

feat(wallet)_: Show buy and receive CTAs on zero balance #21690

smohamedjavid commented Nov 26, 2024 •

edited

Loading

status-im-auto commented Nov 26, 2024 •

edited

Loading

shivekkhurana left a comment

shivekkhurana commented Nov 28, 2024

smohamedjavid commented Nov 28, 2024

clauxx left a comment

status-im-auto commented Nov 28, 2024

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

shivekkhurana commented Nov 29, 2024

shivekkhurana left a comment

smohamedjavid commented Nov 29, 2024

status-im-auto commented Nov 29, 2024

Class TestWalletMultipleDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Nov 29, 2024

feat(wallet)_: Show buy and receive CTAs on zero balance #21690

feat(wallet)_: Show buy and receive CTAs on zero balance #21690

Conversation

smohamedjavid commented Nov 26, 2024 • edited Loading

Summary

Platforms

Steps to test

status-im-auto commented Nov 26, 2024 • edited Loading

Jenkins Builds

shivekkhurana left a comment

Choose a reason for hiding this comment

shivekkhurana commented Nov 28, 2024

smohamedjavid commented Nov 28, 2024

clauxx left a comment

Choose a reason for hiding this comment

status-im-auto commented Nov 28, 2024

88% of end-end tests have passed

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (7)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

shivekkhurana commented Nov 29, 2024

shivekkhurana left a comment

Choose a reason for hiding this comment

smohamedjavid commented Nov 29, 2024

status-im-auto commented Nov 29, 2024

75% of end-end tests have passed

Failed tests (1)

Class TestWalletMultipleDevice:

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (6)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Nov 29, 2024

smohamedjavid commented Nov 26, 2024 •

edited

Loading

status-im-auto commented Nov 26, 2024 •

edited

Loading