[#21436] List of users overlap composer input #21641
Open
+56
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulisesmac
commented
Nov 19, 2024
Comment on lines
+233
to
+229
| :style {:height "100%" | ||
| :background-color (colors/theme-colors colors/white |
There was a problem hiding this comment.
This is the layout fix for the reported issue
ulisesmac
commented
Nov 19, 2024
src/status_im/contexts/chat/messenger/composer/mentions/style.cljs
Outdated
Show resolved
Hide resolved
ulisesmac
commented
Nov 19, 2024
Jenkins BuildsClick to see older builds (9)
|
ulisesmac
force-pushed
the
21436-list-of-users-overlap-input
branch
from
f916a62
to
dc532cd
Compare
ilmotta
approved these changes
Nov 20, 2024
src/status_im/contexts/chat/messenger/composer/mentions/view.cljs
Outdated
Show resolved
Hide resolved
clauxx
approved these changes
Nov 21, 2024
ulisesmac
force-pushed
the
21436-list-of-users-overlap-input
branch
from
dc532cd
to
87cafab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21436
Summary
This PR fixes the styles so that the input is no longer covered.
While solving this, I noticed we were updating the mention's state asynchronously, and it looked as follows:
bug.mp4
Screenshots (to check how the mentions are aligned):
Not it's been fixed and looks as follows:
solved.mp4
Review notes
Testing notes
Platforms
Steps to test
status: ready