[#21573] Keycard - Sign up with a new Keycard #21623

flexsurfer · 2024-11-14T11:34:24Z

status-im-auto · 2024-11-14T11:37:49Z

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`2fd7dca`	#1	2024-11-14 11:37:48	~3 min	`tests`	📄`log`
✔️	`2fd7dca`	#1	2024-11-14 11:41:46	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`2fd7dca`	#1	2024-11-14 11:43:19	~8 min	`android`	🤖`apk` 📲
✔️	`2fd7dca`	#1	2024-11-14 11:43:39	~8 min	`ios`	📱`ipa` 📲

❌	`16fc393`	#2	2024-11-20 15:12:27	~2 min	`tests`	📄`log`
✔️	`16fc393`	#2	2024-11-20 15:19:24	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`16fc393`	#2	2024-11-20 15:20:28	~10 min	`ios`	📱`ipa` 📲
✔️	`16fc393`	#2	2024-11-20 15:21:04	~11 min	`android`	🤖`apk` 📲

✔️	`97ad702`	#3	2024-11-20 15:34:43	~4 min	`tests`	📄`log`
✔️	`97ad702`	#3	2024-11-20 15:37:07	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`97ad702`	#3	2024-11-20 15:37:54	~7 min	`android`	🤖`apk` 📲
✔️	`97ad702`	#3	2024-11-20 15:38:47	~8 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`b2d9a16`	#4	2024-11-22 13:28:45	~4 min	`tests`	📄`log`
✔️	`b2d9a16`	#4	2024-11-22 13:30:50	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b2d9a16`	#4	2024-11-22 13:31:19	~7 min	`android`	🤖`apk` 📲
✔️	`b2d9a16`	#4	2024-11-22 13:33:06	~9 min	`ios`	📱`ipa` 📲

✔️	`45e10ef`	#5	2024-11-22 17:20:40	~4 min	`tests`	📄`log`
✔️	`45e10ef`	#5	2024-11-22 17:23:13	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`45e10ef`	#5	2024-11-22 17:24:08	~8 min	`android`	🤖`apk` 📲
✔️	`45e10ef`	#5	2024-11-22 17:26:53	~10 min	`ios`	📱`ipa` 📲

status-im-auto · 2024-11-20T15:41:48Z

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 1
Passed tests: 7

IDs of expected to fail tests: 702843

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (7)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

mariia-skrypnyk · 2024-11-21T15:41:48Z

Hey @flexsurfer !

Thanks for your PR!

I found one issue with PIN code validation.
Please take a look!

ISSUE 1: no PIN validation in case user enters wrong PIN

Precondition: Keycard with a set PIN

Steps:

Install app
Go to Create user with a Keycard
Scan Keycard
Enter wrong PIN
Scan Keycard
Scan Keycard 2-3 times more and you will get locked card

Actual result:

no validation that PIN is incorrect

IMG_3920.MP4

Expected result:

as a User I would like to see smth like this

flexsurfer · 2024-11-22T13:23:55Z

thank you @mariia-skrypnyk should be fixed

mariia-skrypnyk · 2024-11-22T15:11:50Z

Hi @flexsurfer !

No text with number of attempts on both platforms.

flexsurfer · 2024-11-22T15:15:41Z

No text with number of attempts on both platforms.

i believe there is a separate bug which i can't reproduce :(

status-im-auto · 2024-11-22T16:46:48Z

0% of end-end tests have passed

Total executed tests: 8
Failed tests: 7
Expected to fail tests: 1
Passed tests: 0

IDs of failed tests: 727231,727230,702745,703133,740490,702742,727229

IDs of expected to fail tests: 702843

Failed tests (7)

Click to expand

Rerun failed tests

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:280: in recover_access self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
2. test_wallet_balance_mainnet, id: 740490
Device 1: Find `Button` by `xpath`: `//*[@text="Confirm password"]` Device 1: Tap on found: Button Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:280: in recover_access self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device 2: Find Button by xpath: //*[@text="Confirm password"]
Device 2: Tap on found: Button

Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:254: in create_user
    self.chats_tab.wait_for_visibility_of_element(30)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:280: in recover_access self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
2. test_wallet_send_eth, id: 727229
Device 2: Find `Button` by `xpath`: `//[@text="Confirm password"]` Device 2: Tap on found: Button Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, **self.kwargs) ../views/sign_in_view.py:280: in recover_access self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:254: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device 1: Find `Button` by `xpath`: `//*[@text="Confirm password"]` Device 1: Tap on found: Button Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:254: in create_user self.chats_tab.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

status-im-auto · 2024-11-22T17:46:19Z

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 1
Passed tests: 7

IDs of expected to fail tests: 702843

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (7)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

ilmotta

Code wise PR LGTM. Thank you @flexsurfer

@flexsurfer @mariia-skrypnyk, the following bug always happens to me in iPhone Max 14 Pro. Because of this bug I can't complete the journey. Please, have a look:

Factory reset keycard or use empty one.
Open Status > Create profile > Use Keycard
In the Create profile on empty Keycard screen, press Scan Keycard
In the Keycard is empty screen, press Let's go! to create a new profile.
Backup recovery phrase and continue.
Create pin
In the Ready to add key pair to Keycard screen, press Ready to Scan
Try to scan the keycard. Scanning never works in this step and then it always happens as in the video below, where we can see that after not being able to scan the card, when pressing again Ready to Scan the Oops, this isn't a Keycard screen immediately appears simultaneously with the pop-up Ready to Scan successful even though I didn't even had the time to scan the second time. Finally at the end of the video we see pressing Try again shows the Keycard is not empty.
After the above steps, I have to reset the card in the desktop app, but trying again leads to the same bug.

keycard.mp4

flexsurfer added the keycard label Nov 14, 2024

flexsurfer self-assigned this Nov 14, 2024

flexsurfer force-pushed the feature/keycard-Sign_up_with_a_new_Keycard_#21573 branch from 2fd7dca to 16fc393 Compare November 20, 2024 15:09

flexsurfer changed the title ~~[WIP] [#21573] Keycard - Sign up with a new Keycard~~ [#21573] Keycard - Sign up with a new Keycard Nov 20, 2024

flexsurfer requested review from seanstrom, ilmotta and Parveshdhull November 20, 2024 15:11

flexsurfer added the request-manual-qa label Nov 20, 2024

Parveshdhull approved these changes Nov 20, 2024

View reviewed changes

mariia-skrypnyk self-assigned this Nov 20, 2024

mariia-skrypnyk mentioned this pull request Nov 20, 2024

The main part of a backup flow is missing at Keycard migration flow #21652

Open

mariia-skrypnyk added test cases required Tested - Issues labels Nov 21, 2024

flexsurfer removed the Tested - Issues label Nov 22, 2024

flexsurfer added 3 commits November 22, 2024 19:15

[#21573] Keycard - Sign up with a new Keycard

041d8d1

translations

ee60767

fix enter pin

45e10ef

yevh-berdnyk force-pushed the feature/keycard-Sign_up_with_a_new_Keycard_#21573 branch from b2d9a16 to 45e10ef Compare November 22, 2024 17:15

ilmotta mentioned this pull request Nov 22, 2024

Update create profile and sign in screen #21609

Open

ilmotta reviewed Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#21573] Keycard - Sign up with a new Keycard #21623

[#21573] Keycard - Sign up with a new Keycard #21623

flexsurfer commented Nov 14, 2024

status-im-auto commented Nov 14, 2024 •

edited

Loading

status-im-auto commented Nov 20, 2024

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

mariia-skrypnyk commented Nov 21, 2024

flexsurfer commented Nov 22, 2024

mariia-skrypnyk commented Nov 22, 2024

flexsurfer commented Nov 22, 2024

status-im-auto commented Nov 22, 2024

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Nov 22, 2024

Class TestCommunityMultipleDeviceMerged:

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

ilmotta left a comment

[#21573] Keycard - Sign up with a new Keycard #21623

Are you sure you want to change the base?

[#21573] Keycard - Sign up with a new Keycard #21623

Conversation

flexsurfer commented Nov 14, 2024

status-im-auto commented Nov 14, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Nov 20, 2024

88% of end-end tests have passed

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (7)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestWalletMultipleDevice:

mariia-skrypnyk commented Nov 21, 2024

flexsurfer commented Nov 22, 2024

mariia-skrypnyk commented Nov 22, 2024

flexsurfer commented Nov 22, 2024

status-im-auto commented Nov 22, 2024

0% of end-end tests have passed

Failed tests (7)

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

status-im-auto commented Nov 22, 2024

88% of end-end tests have passed

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (7)

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

ilmotta left a comment

Choose a reason for hiding this comment

status-im-auto commented Nov 14, 2024 •

edited

Loading