Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add spacing between wrong-password error and forgot-password link #21594

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

seanstrom
Copy link
Member

fixes #21207

Summary

  • This PR attempts to fix an appearance issue when submitting an incorrect password when attuning to sign-in to a profile. Now the "oops, wrong password" error message and the "forgot password?" link will have spacing between them.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Places where the password input is used for authentication, for example:
    • Profile login

Steps to test

  • Open Status mobile app
  • Attempt to sign-in to a profile with the wrong password
  • Confirm that the wrong-password error message and the forgot-password link are spaced correctly.

Before and after screenshots comparison

After changes

Screenshot 2024-11-06 at 10 35 13

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Nov 6, 2024

Jenkins Builds

Click to see older builds (23)
Commit #️⃣ Finished (UTC) Duration Platform Result
6996e36 #1 2024-11-06 18:44:26 ~3 min ios 📄log
6996e36 #1 2024-11-06 18:45:17 ~3 min tests 📄log
✔️ 6996e36 #1 2024-11-06 18:50:48 ~9 min android-e2e 🤖apk 📲
✔️ 6996e36 #1 2024-11-06 18:51:19 ~9 min android 🤖apk 📲
16e4093 #2 2024-11-06 23:40:12 ~2 min ios 📄log
✔️ 16e4093 #2 2024-11-06 23:41:50 ~4 min tests 📄log
✔️ 16e4093 #2 2024-11-06 23:45:00 ~7 min android-e2e 🤖apk 📲
✔️ 16e4093 #2 2024-11-06 23:45:43 ~8 min android 🤖apk 📲
16e4093 #3 2024-11-07 00:27:05 ~1 min ios 📄log
16e4093 #4 2024-11-07 16:45:19 ~1 min ios 📄log
16e4093 #5 2024-11-07 17:31:29 ~1 min ios 📄log
✔️ 2af39ac #3 2024-11-12 18:21:02 ~4 min tests 📄log
✔️ 2af39ac #3 2024-11-12 18:24:36 ~7 min android-e2e 🤖apk 📲
✔️ 2af39ac #3 2024-11-12 18:25:15 ~8 min android 🤖apk 📲
✔️ 2af39ac #6 2024-11-12 18:26:27 ~9 min ios 📱ipa 📲
✔️ 16c6c29 #4 2024-11-13 22:12:34 ~4 min tests 📄log
✔️ 16c6c29 #4 2024-11-13 22:16:14 ~7 min android-e2e 🤖apk 📲
✔️ 16c6c29 #4 2024-11-13 22:16:49 ~8 min android 🤖apk 📲
✔️ 16c6c29 #7 2024-11-13 22:18:20 ~9 min ios 📱ipa 📲
✔️ 551c8c4 #5 2024-11-18 17:15:24 ~4 min tests 📄log
551c8c4 #5 2024-11-18 17:18:07 ~7 min android 📄log
✔️ 551c8c4 #5 2024-11-18 17:18:21 ~7 min android-e2e 🤖apk 📲
✔️ 551c8c4 #8 2024-11-18 17:21:04 ~10 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a1425c9 #6 2024-11-20 17:20:18 ~4 min tests 📄log
✔️ a1425c9 #6 2024-11-20 17:22:49 ~7 min android-e2e 🤖apk 📲
✔️ a1425c9 #6 2024-11-20 17:23:36 ~8 min android 🤖apk 📲
✔️ 167575f #7 2024-11-21 19:03:32 ~6 min tests 📄log
✔️ 167575f #7 2024-11-21 19:06:13 ~9 min android-e2e 🤖apk 📲
✔️ 167575f #10 2024-11-21 19:06:16 ~9 min ios 📱ipa 📲
✔️ 167575f #7 2024-11-21 19:06:31 ~9 min android 🤖apk 📲

Copy link
Contributor

@ulisesmac ulisesmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it, it annoys me a lot!

@seanstrom seanstrom force-pushed the seanstrom/fix-wrong-password-message-format branch from 6996e36 to 16e4093 Compare November 6, 2024 23:37
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 1
Passed tests: 7
IDs of expected to fail tests: 702843 

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Test is not run, e2e blocker  

[[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (7)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
2. test_wallet_balance_mainnet, id: 740490

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions

@seanstrom seanstrom force-pushed the seanstrom/fix-wrong-password-message-format branch 3 times, most recently from 16c6c29 to 551c8c4 Compare November 18, 2024 17:10
@mariia-skrypnyk
Copy link

Hey @seanstrom !

Do you need any help from QA side?

@seanstrom seanstrom force-pushed the seanstrom/fix-wrong-password-message-format branch from 551c8c4 to a1425c9 Compare November 20, 2024 17:15
@seanstrom
Copy link
Member Author

Hey @mariia-skrypnyk 👋

I think I just need a quick check on e2e tests, I think my changes should be unrelated to any failures.
If I'm all good on e2e stuff, I'll move this through to design review 🎨

@yevh-berdnyk
Copy link
Contributor

Hi @seanstrom, e2e failure is not PR related, thanks!

@seanstrom seanstrom force-pushed the seanstrom/fix-wrong-password-message-format branch from a1425c9 to 167575f Compare November 21, 2024 18:56
@seanstrom
Copy link
Member Author

@Francesca-G I think this PR is ready for a design-review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Design review
Development

Successfully merging this pull request may close these issues.

Missing spacing in the Wrong password message
6 participants