Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nix interpreter from 2.19.3 to 2.24.10 #21547

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

siddarthkay
Copy link
Contributor

Summary

This PR upgrades nix to 2.24.10.
We also fix the following warnings :

warning: ignoring the client-specified setting 'keep-derivations', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'keep-outputs', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'stalled-download-timeout', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'trusted-public-keys', because it is a restricted setting and you are not a trusted user
warning: ignoring the client-specified setting 'trusted-substituters', because it is a restricted setting and you are not a trusted user

Review notes (warning this maybe time consuming)

  • make nix-purge
  • restart your system
  • make shell will then install nix 2.24.10 for you.
  • Please test common workflows and make commands like :
    • make run-ios
    • make run-android
    • make run-clojure

Testing notes

should not be needed.

Platforms

  • Android
  • iOS

status: ready

@siddarthkay siddarthkay self-assigned this Nov 1, 2024
@siddarthkay siddarthkay requested a review from a team November 1, 2024 17:24
@status-im-auto
Copy link
Member

status-im-auto commented Nov 1, 2024

Jenkins Builds

Click to see older builds (25)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 72ec1dc #1 2024-11-01 17:28:31 ~4 min tests 📄log
✔️ 72ec1dc #1 2024-11-01 17:31:47 ~7 min android-e2e 🤖apk 📲
✔️ 72ec1dc #1 2024-11-01 17:32:13 ~8 min android 🤖apk 📲
✔️ 72ec1dc #1 2024-11-01 17:33:11 ~9 min ios 📱ipa 📲
bcfce20 #2 2024-11-01 18:14:38 ~43 sec tests 📄log
bcfce20 #2 2024-11-01 18:14:39 ~44 sec android 📄log
bcfce20 #2 2024-11-01 18:14:39 ~49 sec android-e2e 📄log
✔️ bcfce20 #2 2024-11-01 18:22:39 ~8 min ios 📱ipa 📲
bcfce20 #3 2024-11-02 01:22:11 ~17 sec android 📄log
bcfce20 #4 2024-11-02 01:23:40 ~14 sec android 📄log
bcfce20 #5 2024-11-02 01:38:46 ~14 sec android 📄log
bcfce20 #6 2024-11-02 01:39:47 ~14 sec android 📄log
bcfce20 #7 2024-11-02 01:40:58 ~14 sec android 📄log
✔️ 91b73d7 #3 2024-11-02 03:22:51 ~8 min ios 📱ipa 📲
91b73d7 #3 2024-11-02 03:34:29 ~20 min tests 📄log
✔️ 91b73d7 #3 2024-11-02 03:51:49 ~37 min android-e2e 🤖apk 📲
✔️ 91b73d7 #10 2024-11-02 03:53:09 ~39 min android 🤖apk 📲
✔️ da9ca9c #4 2024-11-02 04:28:37 ~8 min ios 📱ipa 📲
✔️ da9ca9c #4 2024-11-02 04:28:45 ~8 min android-e2e 🤖apk 📲
✔️ da9ca9c #11 2024-11-02 04:29:13 ~9 min android 🤖apk 📲
✔️ da9ca9c #4 2024-11-02 04:33:37 ~13 min tests 📄log
✔️ 76d96fe #6 2024-11-12 08:14:58 ~6 min tests 📄log
✔️ 76d96fe #6 2024-11-12 08:17:10 ~9 min ios 📱ipa 📲
✔️ 76d96fe #6 2024-11-12 08:19:10 ~11 min android-e2e 🤖apk 📲
✔️ 76d96fe #13 2024-11-12 08:20:47 ~12 min android 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ abce2a2 #7 2024-11-19 10:01:30 ~5 min tests 📄log
✔️ abce2a2 #7 2024-11-19 10:04:41 ~8 min ios 📱ipa 📲
✔️ abce2a2 #7 2024-11-19 10:05:42 ~9 min android-e2e 🤖apk 📲
✔️ abce2a2 #14 2024-11-19 10:06:16 ~10 min android 🤖apk 📲
✔️ 824993e #8 2024-11-20 07:57:13 ~5 min tests 📄log
✔️ 824993e #8 2024-11-20 08:00:59 ~8 min ios 📱ipa 📲
✔️ 824993e #8 2024-11-20 08:01:40 ~9 min android-e2e 🤖apk 📲
✔️ 824993e #15 2024-11-20 08:02:15 ~10 min android 🤖apk 📲

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this.

nix/shell.nix Outdated Show resolved Hide resolved
nix/nix.conf Outdated Show resolved Hide resolved
ci/Jenkinsfile.tests Outdated Show resolved Hide resolved
@siddarthkay siddarthkay force-pushed the upgrade-nix-2.24.x branch 2 times, most recently from a8f57d1 to 76d96fe Compare November 12, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: CONTRIBUTOR
Development

Successfully merging this pull request may close these issues.

3 participants