fix: notification center blur #19861

codemaster115 · 2024-05-01T12:29:46Z

fixes #19181

Summary

Shell - notification screen issue

Wrong dark overlay color
Wrong color of tags and date caused by the above issue.

Platforms

Android
iOS

Areas that maybe impacted

Functional

activity center

Steps to test

Open Status
Open Notification Center by pressing notification icon on the top-right of screen.

Before and after screenshots comparison

status: ready

status-im-auto · 2024-05-01T12:34:24Z

Jenkins Builds

Click to see older builds (36)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`83f09d2`	#1	2024-05-01 12:34:23	~4 min	`tests`	📄`log`
✔️	`83f09d2`	#1	2024-05-01 12:37:08	~7 min	`android`	🤖`apk` 📲
✔️	`83f09d2`	#1	2024-05-01 12:39:08	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`83f09d2`	#1	2024-05-01 12:39:32	~9 min	`ios`	📱`ipa` 📲

✔️	`586a220`	#2	2024-05-01 18:17:04	~7 min	`tests`	📄`log`
✔️	`586a220`	#2	2024-05-01 18:21:11	~11 min	`ios`	📱`ipa` 📲
✔️	`586a220`	#2	2024-05-01 18:22:08	~12 min	`android-e2e`	🤖`apk` 📲
✔️	`586a220`	#2	2024-05-01 18:22:21	~12 min	`android`	🤖`apk` 📲

✔️	`bfc6a08`	#3	2024-05-02 12:58:59	~7 min	`tests`	📄`log`
✔️	`bfc6a08`	#3	2024-05-02 13:01:13	~9 min	`ios`	📱`ipa` 📲
✔️	`bfc6a08`	#3	2024-05-02 13:04:14	~12 min	`android`	🤖`apk` 📲
✔️	`bfc6a08`	#3	2024-05-02 13:04:19	~12 min	`android-e2e`	🤖`apk` 📲

✔️	`f41a5ea`	#4	2024-05-03 13:41:24	~3 min	`tests`	📄`log`
✔️	`f41a5ea`	#4	2024-05-03 13:46:14	~8 min	`ios`	📱`ipa` 📲
✔️	`f41a5ea`	#4	2024-05-03 13:49:24	~11 min	`android`	🤖`apk` 📲
✔️	`f41a5ea`	#4	2024-05-03 13:49:29	~11 min	`android-e2e`	🤖`apk` 📲

✔️	`c4abb8f`	#5	2024-05-06 12:57:41	~7 min	`tests`	📄`log`
✔️	`c4abb8f`	#5	2024-05-06 12:59:00	~8 min	`ios`	📱`ipa` 📲
✔️	`c4abb8f`	#5	2024-05-06 13:03:01	~12 min	`android-e2e`	🤖`apk` 📲
✔️	`c4abb8f`	#5	2024-05-06 13:03:08	~12 min	`android`	🤖`apk` 📲

❌	`88a63d7`	#7	2024-05-06 13:35:47	~2 min	`tests`	📄`log`
✔️	`88a63d7`	#7	2024-05-06 13:39:26	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`88a63d7`	#7	2024-05-06 13:42:43	~9 min	`android`	🤖`apk` 📲
✔️	`88a63d7`	#7	2024-05-06 13:43:31	~10 min	`ios`	📱`ipa` 📲

❌	`f8d32c5`	#8	2024-05-06 14:18:42	~4 min	`tests`	📄`log`
✔️	`f8d32c5`	#8	2024-05-06 14:22:47	~8 min	`ios`	📱`ipa` 📲
✔️	`f8d32c5`	#8	2024-05-06 14:26:11	~11 min	`android-e2e`	🤖`apk` 📲
✔️	`f8d32c5`	#8	2024-05-06 14:26:16	~11 min	`android`	🤖`apk` 📲

❌	`d74c8cb`	#9	2024-05-06 15:35:47	~4 min	`tests`	📄`log`
✔️	`d74c8cb`	#9	2024-05-06 15:39:37	~8 min	`ios`	📱`ipa` 📲
✔️	`d74c8cb`	#9	2024-05-06 15:43:07	~11 min	`android-e2e`	🤖`apk` 📲
✔️	`d74c8cb`	#9	2024-05-06 15:43:14	~12 min	`android`	🤖`apk` 📲

✔️	`40db16c`	#10	2024-05-06 19:47:42	~8 min	`ios`	📱`ipa` 📲
✔️	`40db16c`	#10	2024-05-06 19:51:28	~12 min	`android-e2e`	🤖`apk` 📲
✔️	`40db16c`	#10	2024-05-06 19:51:31	~12 min	`android`	🤖`apk` 📲
✔️	`40db16c`	#11	2024-05-06 20:12:26	~4 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`7c90542`	#12	2024-05-07 12:55:29	~5 min	`tests`	📄`log`
✔️	`7c90542`	#11	2024-05-07 12:58:55	~9 min	`ios`	📱`ipa` 📲
✔️	`7c90542`	#11	2024-05-07 13:02:50	~13 min	`android-e2e`	🤖`apk` 📲
✔️	`7c90542`	#11	2024-05-07 13:04:10	~14 min	`android`	🤖`apk` 📲

✔️	`9dd48da`	#13	2024-05-07 13:26:40	~6 min	`tests`	📄`log`
✔️	`9dd48da`	#12	2024-05-07 13:29:38	~9 min	`ios`	📱`ipa` 📲
✔️	`9dd48da`	#12	2024-05-07 13:31:53	~12 min	`android-e2e`	🤖`apk` 📲
✔️	`9dd48da`	#12	2024-05-07 13:32:04	~12 min	`android`	🤖`apk` 📲

Parveshdhull · 2024-05-01T12:42:55Z

src/status_im/contexts/shell/activity_center/style.cljs

@@ -56,5 +56,5 @@

 (def blur
 {:style {:position :absolute :top 0 :left 0 :right 0 :bottom 0}
- :overlayColor colors/neutral-80-opa-80
+ :overlayColor colors/neutral-80-opa-80-blur


ibrkhalil

✅

status-im-auto · 2024-05-01T18:32:38Z

87% of end-end tests have passed

Total executed tests: 52
Failed tests: 5
Expected to fail tests: 2
Passed tests: 45

IDs of failed tests: 727230,702782,702783,727229,703391

IDs of expected to fail tests: 703495,703503

Failed tests (5)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 1: Find `BaseElement` by `xpath`: `//[@content-desc=':chat-floating-screen']//[starts-with(@text,'💇🏻‍♂️')]` Device 1: Long press on `BaseElement` until expected element is shown critical/chats/test_1_1_public_chats.py:117: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_1.quote_message(emoji_unicode) ../views/chat_view.py:1040: in quote_message self.chat_view_element_starts_with_text(message).long_press_until_element_is_shown(self.reply_message_button) ../views/base_element.py:331: in long_press_until_element_is_shown action.long_press(element).release().perform() ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:174: in perform self._driver.execute(Command.TOUCH_ACTION, params) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace)) The element 'By.xpath: //[@content-desc=':chat-floating-screen']//[starts-with(@text,'💇🏻‍♂️')]' is not linked to the same object in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception E Stacktrace: E io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //[@content-desc=':chat-floating-screen']//[starts-with(@text,'💇🏻‍♂️')]' is not linked to the same object in DOM anymore E at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:122) E at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153) E at io.appium.uiautomator2.handler.Location.safeHandle(Location.java:23) E at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59) E at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277) E at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271) E at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435) E at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293) E at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267) E at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345) E at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366) E at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352) E at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911) E at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131) E at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611) E at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552) E at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466) E at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438) E at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140) E at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144) E at java.lang.Thread.run(Thread.java:1012) Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_send_image_save_and_share, id: 703391
Device 2: Find `Button` by `accessibility id`: `image-0` Device 2: Click system back button `critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Not expected image is shown to the receiver.` Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:614: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not changed to Delivered, it's Sent after back up online!` Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
# STEP: Getting ETH amount in the wallet of the sender before transaction Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab` critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:39: in _get_balances_before_tx self.wallet_1.wallet_tab.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_send_eth, id: 727229
Device 1: Swiping right on element SlideButton Device 1: Find `SlideButton` by `xpath`: `//[@resource-id='slide-button-track']` critical/test_wallet.py:109: in test_wallet_send_eth self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send) ../views/wallet_view.py:97: in send_asset self.confirm_transaction() ../views/wallet_view.py:84: in confirm_transaction self.slide_and_confirm_with_password() ../views/wallet_view.py:78: in slide_and_confirm_with_password self.slide_button_track.slide() ../views/base_view.py:257: in slide self.swipe_right_on_element(width_percentage=1.3, start_x=100) ../views/base_element.py:308: in swipe_right_on_element location, size = self.get_element_coordinates() ../views/base_element.py:294: in get_element_coordinates element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: SlideButton by xpath: `//[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Expected to fail tests (2)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
# STEP: Change device time so chat will be unmuted by timer Device 2: Long press on `ChatElement` `critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat is still muted after timeout` [[Chat is not unmuted after expected time: https://github.com//issues/19627]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (45)

Click to expand

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs
2. test_wallet_add_remove_watch_only_account, id: 727232
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

status-im-auto · 2024-05-02T10:00:34Z

40% of end-end tests have passed

Total executed tests: 5
Failed tests: 3
Expected to fail tests: 0
Passed tests: 2

IDs of failed tests: 727230,703391,727229

Failed tests (3)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Device 1: Long press on `AssetElement` Device 1: Find `EditBox` by `accessibility id`: `address-text-input` critical/test_wallet.py:123: in test_wallet_send_asset_from_drawer self.wallet_1.send_asset_from_drawer(address=self.receiver['address'], asset_name='Ether', ../views/wallet_view.py:104: in send_asset_from_drawer self.address_text_input.send_keys(address) ../views/base_element.py:377: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `address-text-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_send_eth, id: 727229
Device 1: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]` Device 1: `Text` is `0.03739 ETH` `critical/test_wallet.py:112: in test_wallet_send_eth self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender, critical/test_wallet.py:98: in _check_balances_after_tx self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Eth amount in the receivers wallet is 0.0333 but should be 0.0334 E Eth amount in the senders wallet is 0.0374 but should be 0.0373`

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_send_image_save_and_share, id: 703391

Device 2: Find Button by accessibility id: image-0
Device 2: Click system back button

critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Passed tests (2)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2024-05-02T10:04:24Z

Hi @codemaster115, thanks for the PR!
Could you please clarify one moment that is not entirely clear from the PR description: does this PR completely fix the issue #19181 or only Wrong dark overlay color?

The thing is that once this PR is merged, the entire issue will be closed, which will be wrong since there are several more comments from the designers besides the wrong overlay color.
In this case please update the PR description or/and the issue accordingly.
Thank you!

codemaster115 · 2024-05-02T12:33:48Z

Hi @codemaster115, thanks for the PR! Could you please clarify one moment that is not entirely clear from the PR description: does this PR completely fix the issue #19181 or only Wrong dark overlay color?

The thing is that once this PR is merged, the entire issue will be closed, which will be wrong since there are several more comments from the designers besides the wrong overlay color. In this case please update the PR description or/and the issue accordingly. Thank you!

@qoqobolo I just updated the PR description that it completely resolved the issue.

qoqobolo · 2024-05-02T13:27:28Z

Thank you @codemaster115 !
I smoke-tested it, and everything looks good. E2e failures are not PR-related.
I also think manual testing could be skipped in this PR according to the new process (please read it if you haven’t already: https://github.com/status-im/status-mobile/blob/develop/doc/pipeline_process.md)

So, the PR is ready for design review, @Francesca-G please check the fixes from your perspective, thank you! 🙏✨

Francesca-G

Overlay color looks much better, nice job ✨

About the tag: please make sure the text and the icon are in Success/Solid/50 so they're readable as per design:

(implementation on the left, design on the right)

codemaster115 · 2024-05-06T13:32:32Z

Overlay color looks much better, nice job ✨

About the tag: please make sure the text and the icon are in Success/Solid/50 so they're readable as per design:
>
(implementation on the left, design on the right)

@Francesca-G Please review it again. Just fixed

Francesca-G

Looks good now 👍

codemaster115 requested review from flexsurfer, Parveshdhull and ibrkhalil May 1, 2024 12:29

codemaster115 self-assigned this May 1, 2024

codemaster115 linked an issue May 1, 2024 that may be closed by this pull request

Shell - Notification Center screen issues #19181

Closed

status-github-bot bot added this to REVIEW in Pipeline for QA May 1, 2024

Parveshdhull approved these changes May 1, 2024

View reviewed changes

ibrkhalil approved these changes May 1, 2024

View reviewed changes

codemaster115 moved this from REVIEW to E2E Tests in Pipeline for QA May 1, 2024

codemaster115 added the request-manual-qa label May 1, 2024

codemaster115 force-pushed the 19181-shell---notification-center-screen-issues branch from 83f09d2 to 586a220 Compare May 1, 2024 18:09

qoqobolo self-assigned this May 2, 2024

qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA May 2, 2024

codemaster115 force-pushed the 19181-shell---notification-center-screen-issues branch from 586a220 to bfc6a08 Compare May 2, 2024 12:51

qoqobolo added the Tested - OK label May 2, 2024

qoqobolo moved this from IN TESTING to Design review in Pipeline for QA May 2, 2024

qoqobolo added the design-review-required label May 2, 2024

Francesca-G reviewed May 3, 2024

View reviewed changes

codemaster115 force-pushed the 19181-shell---notification-center-screen-issues branch 2 times, most recently from f41a5ea to c4abb8f Compare May 6, 2024 12:50

codemaster115 requested a review from Francesca-G May 6, 2024 13:32

codemaster115 force-pushed the 19181-shell---notification-center-screen-issues branch 2 times, most recently from 88a63d7 to f8d32c5 Compare May 6, 2024 14:13

codemaster115 force-pushed the 19181-shell---notification-center-screen-issues branch from f8d32c5 to d74c8cb Compare May 6, 2024 15:30

Francesca-G approved these changes May 7, 2024

View reviewed changes

Francesca-G moved this from Design review to MERGE in Pipeline for QA May 7, 2024

codemaster115 added 3 commits May 7, 2024 05:49

fix: notification center blur

6b11473

fix: tag color

f276f59

fix: lint

7c90542

codemaster115 force-pushed the 19181-shell---notification-center-screen-issues branch from 40db16c to 7c90542 Compare May 7, 2024 12:49

fix: lint

9dd48da

codemaster115 merged commit be59785 into develop May 7, 2024
6 checks passed

Pipeline for QA automation moved this from MERGE to DONE May 7, 2024

codemaster115 deleted the 19181-shell---notification-center-screen-issues branch May 7, 2024 13:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: notification center blur #19861

fix: notification center blur #19861

codemaster115 commented May 1, 2024 •

edited

status-im-auto commented May 1, 2024 •

edited

Parveshdhull May 1, 2024

ibrkhalil left a comment

status-im-auto commented May 1, 2024

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestWalletMultipleDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestDeepLinksOneDevice:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

status-im-auto commented May 2, 2024

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

qoqobolo commented May 2, 2024 •

edited

codemaster115 commented May 2, 2024

qoqobolo commented May 2, 2024

Francesca-G left a comment

codemaster115 commented May 6, 2024

Francesca-G left a comment

fix: notification center blur #19861

fix: notification center blur #19861

Conversation

codemaster115 commented May 1, 2024 • edited

Summary

Platforms

Areas that maybe impacted

Functional

Steps to test

Before and after screenshots comparison

status-im-auto commented May 1, 2024 • edited

Jenkins Builds

Parveshdhull May 1, 2024

Choose a reason for hiding this comment

ibrkhalil left a comment

Choose a reason for hiding this comment

status-im-auto commented May 1, 2024

87% of end-end tests have passed

Failed tests (5)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestWalletMultipleDevice:

Expected to fail tests (2)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Passed tests (45)

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestDeepLinksOneDevice:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

status-im-auto commented May 2, 2024

40% of end-end tests have passed

Failed tests (3)

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (2)

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

qoqobolo commented May 2, 2024 • edited

codemaster115 commented May 2, 2024

qoqobolo commented May 2, 2024

Francesca-G left a comment

Choose a reason for hiding this comment

codemaster115 commented May 6, 2024

Francesca-G left a comment

Choose a reason for hiding this comment

codemaster115 commented May 1, 2024 •

edited

status-im-auto commented May 1, 2024 •

edited

qoqobolo commented May 2, 2024 •

edited