Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial handlers update (re-frame/reg-event-fx instead of rf/defn) #19708

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Apr 18, 2024

This PR aims to update quite some namespace to match the new guidelines: https://github.com/status-im/status-mobile/blob/9fab422e0c9fa7c72bdc2dff8973785b768721ca/doc/new-guidelines.md#registering-event-handlers

Most of the work was done already in this PR: #19005
This is basically the extension of it to the whole status-im.contexts.profile namespace.

Functional
  • account recovery
  • new account
  • user profile updates

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 18, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 18, 2024

Jenkins Builds

Click to see older builds (28)
Commit #️⃣ Finished (UTC) Duration Platform Result
f04f138 #1 2024-04-18 10:36:14 ~2 min tests 📄log
✔️ f04f138 #1 2024-04-18 10:40:35 ~6 min android 🤖apk 📲
✔️ f04f138 #1 2024-04-18 10:40:44 ~7 min android-e2e 🤖apk 📲
✔️ f04f138 #1 2024-04-18 10:46:01 ~12 min ios 📱ipa 📲
1bbfd22 #2 2024-04-18 14:14:52 ~2 min tests 📄log
✔️ 1bbfd22 #2 2024-04-18 14:18:45 ~6 min android-e2e 🤖apk 📲
✔️ 1bbfd22 #2 2024-04-18 14:20:45 ~8 min android 🤖apk 📲
✔️ 1bbfd22 #2 2024-04-18 14:23:16 ~11 min ios 📱ipa 📲
5a6ae26 #3 2024-04-18 14:50:07 ~2 min tests 📄log
✔️ 5a6ae26 #3 2024-04-18 14:54:33 ~6 min android 🤖apk 📲
✔️ 5a6ae26 #3 2024-04-18 14:54:50 ~7 min android-e2e 🤖apk 📲
✔️ 5a6ae26 #3 2024-04-18 15:12:06 ~24 min ios 📱ipa 📲
702da7a #4 2024-04-19 09:11:06 ~2 min tests 📄log
✔️ 702da7a #4 2024-04-19 09:14:50 ~5 min android 🤖apk 📲
✔️ 702da7a #4 2024-04-19 09:14:58 ~5 min android-e2e 🤖apk 📲
✔️ 702da7a #4 2024-04-19 09:18:37 ~9 min ios 📱ipa 📲
d379d80 #5 2024-04-19 09:22:48 ~2 min tests 📄log
✔️ d379d80 #5 2024-04-19 09:27:25 ~7 min android-e2e 🤖apk 📲
✔️ d379d80 #5 2024-04-19 09:27:29 ~7 min android 🤖apk 📲
✔️ d379d80 #5 2024-04-19 09:28:50 ~8 min ios 📱ipa 📲
c54f291 #6 2024-04-19 09:33:12 ~2 min tests 📄log
✔️ c54f291 #6 2024-04-19 09:38:23 ~7 min android-e2e 🤖apk 📲
✔️ c54f291 #6 2024-04-19 09:38:29 ~7 min android 🤖apk 📲
✔️ c54f291 #6 2024-04-19 09:40:59 ~10 min ios 📱ipa 📲
cce91ab #7 2024-04-19 10:48:41 ~2 min tests 📄log
✔️ cce91ab #7 2024-04-19 10:51:57 ~5 min android-e2e 🤖apk 📲
✔️ cce91ab #7 2024-04-19 10:53:07 ~6 min android 🤖apk 📲
✔️ cce91ab #7 2024-04-19 10:54:57 ~8 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
4d018a3 #8 2024-04-22 15:38:35 ~4 min tests 📄log
✔️ 4d018a3 #8 2024-04-22 15:42:21 ~8 min ios 📱ipa 📲
✔️ 4d018a3 #8 2024-04-22 15:46:04 ~12 min android-e2e 🤖apk 📲
✔️ 4d018a3 #8 2024-04-22 15:46:05 ~12 min android 🤖apk 📲
916c0b9 #9 2024-04-22 21:28:30 ~5 min tests 📄log
✔️ 916c0b9 #9 2024-04-22 21:31:43 ~8 min android-e2e 🤖apk 📲
✔️ 916c0b9 #9 2024-04-22 21:33:05 ~9 min ios 📱ipa 📲
✔️ 916c0b9 #9 2024-04-22 21:33:50 ~10 min android 🤖apk 📲

@alwx alwx self-assigned this Apr 18, 2024
@alwx alwx marked this pull request as ready for review April 19, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Pipeline for QA
  
REVIEW
Development

Successfully merging this pull request may close these issues.

None yet

2 participants