New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: blur type for community header #19665
Conversation
a1b0f16
to
3a29312
Compare
Jenkins BuildsClick to see older builds (55)
|
92% of end-end tests have passed
Failed tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (48)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
3a29312
to
a5b8c38
Compare
a5b8c38
to
dd0bb0d
Compare
dd0bb0d
to
a269f7e
Compare
Hi @BalogunofAfrica ! Thanks for your fix! I've tested on both platforms and found such behaviour on the top on ISSUE 1: white block appears ont he top during scrolling Community Channels Steps:
Expected result: no white block on the top IMG_8091.MP4Device: iOS 13 (17.3.1) |
a269f7e
to
b180695
Compare
@BalogunofAfrica thanks for your fix! ✅ Looks good now! |
460f39e
to
64a9209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments here about the blur color
also:
- When scrolling we have a change in the button bg color that shouldn't be there:
RPReplay_Final1713789973.mp4
- on Android, the bg color looks like a "magnifying glass", It has a different blur effect that's very noticeable when scrolling over the cover image:
64a9209
to
e07bc3f
Compare
@BalogunofAfrica - what's the status of this pr? Also @ulisesmac recently updated something similar, perhaps it affects this? 🤔 |
I can see the fix is only focused on changing the blur type, if so then the fix is OK, just wanted to highlight that this header needs more work, it should look almost as the one in the collectibles header: Android.-.Light.movBut with some differences that match the figma designs NOTE: The collectibles header hasn't been merged |
e07bc3f
to
0f25564
Compare
Hi @Francesca-G this PR would just be to change the blur type. I spoke with @ulisesmac and we agreed we might need to rework the community header which would address some of the comments you raised and others not here. As wallets is the maim priority now, this would be descoped and we can take a look after June/July. I have created an issue for it here: cc: @J-Son89 |
e090f8d
to
0afba5b
Compare
0afba5b
to
c443ee0
Compare
fixes #19205 and item 2 from #19204
Summary
This PR Fixes the issue top nav blur issue on Android where the top blur is not really applied to the top area. It also addresses the issue with iOS blur completely blocking out the community header image .
Platforms
Areas that maybe impacted
Functional
Steps to test
Before and after screenshots comparison
status: ready