Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blur type for community header #19665

Merged
merged 2 commits into from May 16, 2024
Merged

Conversation

BalogunofAfrica
Copy link
Contributor

fixes #19205 and item 2 from #19204

Summary

This PR Fixes the issue top nav blur issue on Android where the top blur is not really applied to the top area. It also addresses the issue with iOS blur completely blocking out the community header image .

Platforms

  • Android
  • iOS

Areas that maybe impacted

  • community
Functional
  • community

Steps to test

  • Open a community
  • Scroll through channels list
  • Observe the blur of the top nav

Before and after screenshots comparison

Figma (if available) iOS (if available) Android (if available)
image Simulator Screen Recording - iPhone 11 Pro - 2024-04-16 at 12 14 21 https://github.com/status-im/status-mobile/assets/45393944/886a2f56-4819-42e6-8aee-c6a7544b8b86

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Apr 16, 2024

Jenkins Builds

Click to see older builds (55)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3a29312 #2 2024-04-16 11:45:28 ~4 min tests 📄log
✔️ 3a29312 #2 2024-04-16 11:47:31 ~6 min android-e2e 🤖apk 📲
✔️ 3a29312 #2 2024-04-16 11:48:20 ~7 min android 🤖apk 📲
✔️ 3a29312 #2 2024-04-16 11:49:49 ~8 min ios 📱ipa 📲
✔️ a5b8c38 #3 2024-04-16 15:31:10 ~4 min tests 📄log
✔️ a5b8c38 #3 2024-04-16 15:33:19 ~6 min android 🤖apk 📲
✔️ a5b8c38 #3 2024-04-16 15:35:30 ~8 min android-e2e 🤖apk 📲
✔️ a5b8c38 #3 2024-04-16 15:35:56 ~9 min ios 📱ipa 📲
✔️ dd0bb0d #4 2024-04-16 16:17:02 ~3 min tests 📄log
✔️ dd0bb0d #4 2024-04-16 16:18:46 ~5 min android-e2e 🤖apk 📲
✔️ dd0bb0d #4 2024-04-16 16:19:26 ~6 min android 🤖apk 📲
✔️ dd0bb0d #4 2024-04-16 16:26:00 ~12 min ios 📱ipa 📲
✔️ a269f7e #5 2024-04-17 14:29:23 ~7 min android-e2e 🤖apk 📲
✔️ a269f7e #5 2024-04-17 14:29:36 ~7 min tests 📄log
✔️ a269f7e #5 2024-04-17 14:29:45 ~7 min android 🤖apk 📲
✔️ a269f7e #5 2024-04-17 14:37:15 ~15 min ios 📱ipa 📲
✔️ b180695 #6 2024-04-18 11:40:01 ~4 min tests 📄log
✔️ b180695 #6 2024-04-18 11:41:34 ~5 min android 🤖apk 📲
✔️ b180695 #6 2024-04-18 11:42:33 ~6 min android-e2e 🤖apk 📲
b180695 #6 2024-04-18 11:44:49 ~9 min ios 📄log
✔️ 460f39e #7 2024-04-18 13:07:50 ~6 min tests 📄log
✔️ 460f39e #7 2024-04-18 13:08:21 ~7 min android-e2e 🤖apk 📲
✔️ 460f39e #7 2024-04-18 13:09:26 ~8 min android 🤖apk 📲
✔️ 460f39e #7 2024-04-18 13:16:09 ~14 min ios 📱ipa 📲
✔️ 64a9209 #8 2024-04-22 05:27:37 ~4 min tests 📄log
✔️ 64a9209 #8 2024-04-22 05:30:35 ~7 min android 🤖apk 📲
✔️ 64a9209 #8 2024-04-22 05:36:46 ~13 min android-e2e 🤖apk 📲
✔️ 64a9209 #8 2024-04-22 05:48:26 ~25 min ios 📱ipa 📲
✔️ e07bc3f #9 2024-04-25 11:46:26 ~5 min android 🤖apk 📲
✔️ e07bc3f #9 2024-04-25 11:46:41 ~5 min tests 📄log
✔️ e07bc3f #9 2024-04-25 11:50:07 ~9 min ios 📱ipa 📲
✔️ e07bc3f #9 2024-04-25 11:50:45 ~10 min android-e2e 🤖apk 📲
✔️ 0f25564 #10 2024-05-15 17:15:50 ~4 min tests 📄log
✔️ 0f25564 #10 2024-05-15 17:16:52 ~5 min android-e2e 🤖apk 📲
✔️ 0f25564 #10 2024-05-15 17:17:07 ~6 min android 🤖apk 📲
✔️ 0f25564 #10 2024-05-15 17:19:55 ~8 min ios 📱ipa 📲
✔️ e1f6f87 #11 2024-05-16 12:44:05 ~6 min android 🤖apk 📲
✔️ e1f6f87 #11 2024-05-16 12:44:20 ~6 min android-e2e 🤖apk 📲
✔️ e1f6f87 #11 2024-05-16 12:45:19 ~7 min tests 📄log
✔️ e1f6f87 #11 2024-05-16 12:50:05 ~12 min ios 📱ipa 📲
✔️ b6089d9 #13 2024-05-16 13:16:28 ~4 min tests 📄log
✔️ b6089d9 #13 2024-05-16 13:20:08 ~8 min android-e2e 🤖apk 📲
✔️ 8eeb382 #14 2024-05-16 13:27:12 ~5 min tests 📄log
✔️ 8eeb382 #14 2024-05-16 13:29:11 ~6 min android 🤖apk 📲
✔️ 8eeb382 #14 2024-05-16 13:32:00 ~9 min android-e2e 🤖apk 📲
✔️ 8eeb382 #14 2024-05-16 13:33:09 ~10 min ios 📱ipa 📲
✔️ ca3bece #16 2024-05-16 13:43:20 ~3 min tests 📄log
✔️ ca3bece #16 2024-05-16 13:45:15 ~5 min android-e2e 🤖apk 📲
✔️ ca3bece #16 2024-05-16 13:49:41 ~10 min android 🤖apk 📲
✔️ ca3bece #16 2024-05-16 13:51:33 ~12 min ios 📱ipa 📲
e090f8d #17 2024-05-16 14:12:04 ~4 min tests 📄log
✔️ e090f8d #17 2024-05-16 14:13:36 ~6 min android 🤖apk 📲
✔️ e090f8d #17 2024-05-16 14:13:42 ~6 min android-e2e 🤖apk 📲
✔️ e090f8d #17 2024-05-16 14:18:45 ~11 min ios 📱ipa 📲
✔️ e090f8d #18 2024-05-16 14:26:06 ~3 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0afba5b #19 2024-05-16 14:39:00 ~5 min tests 📄log
✔️ 0afba5b #18 2024-05-16 14:42:00 ~8 min android-e2e 🤖apk 📲
✔️ 0afba5b #18 2024-05-16 14:42:08 ~8 min android 🤖apk 📲
✔️ 0afba5b #18 2024-05-16 14:46:07 ~12 min ios 📱ipa 📲
✔️ c443ee0 #20 2024-05-16 16:18:12 ~3 min tests 📄log
✔️ c443ee0 #19 2024-05-16 16:20:34 ~6 min android-e2e 🤖apk 📲
✔️ c443ee0 #19 2024-05-16 16:23:02 ~8 min android 🤖apk 📲
✔️ c443ee0 #19 2024-05-16 16:23:18 ~8 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 52
Failed tests: 2
Expected to fail tests: 2
Passed tests: 48
IDs of failed tests: 702851,702869 
IDs of expected to fail tests: 703495,703503 

Failed tests (2)

Click to expand
  • Rerun failed tests

  • Class TestCommunityOneDeviceMerged:

    1. test_community_undo_delete_message, id: 702869

    Device 1: Tap on found: Button
    Device 1: Find `Button` by `xpath`: `//*[@text="Undo"]`

    critical/chats/test_public_chat_browsing.py:112: in test_community_undo_delete_message
        self.channel.element_by_text("Undo").click()
    ../views/base_element.py:92: in click
        element.click()
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:94: in click
        self._execute(Command.CLICK_ELEMENT)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:395: in _execute
        return self._parent.execute(command, params)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
        self.error_handler.check_response(response)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
        raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
     The element 'By.xpath: //*[@text="Undo"]' does not exist in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
    E   Stacktrace:
    E   io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //*[@text="Undo"]' does not exist in DOM anymore
    E   	at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:117)
    E   	at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153)
    E   	at io.appium.uiautomator2.handler.Click.safeHandle(Click.java:36)
    E   	at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59)
    E   	at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277)
    E   	at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271)
    E   	at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
    E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
    E   	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
    E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
    E   	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
    E   	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
    E   	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
    E   	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
    E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
    E   	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
    E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
    E   	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
    E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
    E   	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911)
    E   	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
    E   	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
    E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
    E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
    E   	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
    E   	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
    E   	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
    E   	at java.lang.Thread.run(Thread.java:1012)
    
    During handling of the above exception, another exception occurred:
    critical/chats/test_public_chat_browsing.py:114: in test_community_undo_delete_message
        pytest.fail("Can't press Undo button, not enough time")
    E   Failed: Can't press Undo button, not enough time
    



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 1: Tap on found: Button
    # STEP: Device1 check that contact appeared in contact list mutually

    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
        httplib_response = self._make_request(
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
        six.raise_from(e, None)
    <string>:3: in raise_from
        ???
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
        httplib_response = conn.getresponse()
    /usr/lib/python3.10/http/client.py:1375: in getresponse
        response.begin()
    /usr/lib/python3.10/http/client.py:318: in begin
        version, status, reason = self._read_status()
    /usr/lib/python3.10/http/client.py:287: in _read_status
        raise RemoteDisconnected("Remote end closed connection without"
    E   http.client.RemoteDisconnected: Remote end closed connection without response
    
    During handling of the above exception, another exception occurred:
    activity_center/test_activity_center.py:141: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
        self.device_2.just_fyi('Device1 check that contact appeared in contact list mutually')
    ../views/base_view.py:409: in just_fyi
        self.driver.execute_script("sauce:context=STEP: %s" % some_str)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:405: in execute_script
        return self.execute(command, {"script": script, "args": converted_args})["value"]
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:343: in execute
        response = self.command_executor.execute(driver_command, params)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:291: in execute
        return self._request(command_info[0], url, body=data)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:312: in _request
        response = self._conn.request(method, url, body=body, headers=headers)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/request.py:78: in request
        return self.request_encode_body(
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body
        return self.urlopen(method, url, **extra_kw)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen
        response = conn.urlopen(method, u.request_uri, **kw)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen
        retries = retries.increment(
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment
        raise six.reraise(type(error), error, _stacktrace)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise
        raise value.with_traceback(tb)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
        httplib_response = self._make_request(
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
        six.raise_from(e, None)
    <string>:3: in raise_from
        ???
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
        httplib_response = conn.getresponse()
    /usr/lib/python3.10/http/client.py:1375: in getresponse
        response.begin()
    /usr/lib/python3.10/http/client.py:318: in begin
        version, status, reason = self._read_status()
    /usr/lib/python3.10/http/client.py:287: in _read_status
        raise RemoteDisconnected("Remote end closed connection without"
     ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
    



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
        self.errors.verify_no_errors()
    base_test_case.py:190: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Chat is still muted after timeout 
    

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Passed tests (48)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    Device sessions

    2. test_wallet_send_eth, id: 727229
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    @mariia-skrypnyk mariia-skrypnyk moved this from E2E Tests to IN TESTING in Pipeline for QA Apr 17, 2024
    @mariia-skrypnyk
    Copy link

    Hi @BalogunofAfrica !

    Thanks for your fix!

    I've tested on both platforms and found such behaviour on the top on Community screen on iOS only:

    ISSUE 1: white block appears ont he top during scrolling Community Channels

    Steps:

    1. Login to app
    2. Open Community with 15+ channels
    3. Try to scroll

    Expected result: no white block on the top
    Actual result:

    IMG_8091.MP4

    Device: iOS 13 (17.3.1)

    @mariia-skrypnyk
    Copy link

    @BalogunofAfrica thanks for your fix!

    ✅ Looks good now!
    Move it forward to @Francesca-G review 🔬.

    @mariia-skrypnyk mariia-skrypnyk self-assigned this Apr 18, 2024
    @mariia-skrypnyk mariia-skrypnyk moved this from IN TESTING to Design review in Pipeline for QA Apr 18, 2024
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I left a couple of comments here about the blur color

    also:

    • When scrolling we have a change in the button bg color that shouldn't be there:
    RPReplay_Final1713789973.mp4
    • on Android, the bg color looks like a "magnifying glass", It has a different blur effect that's very noticeable when scrolling over the cover image:
    Screenshot 2024-04-22 alle 14 40 52

    @J-Son89
    Copy link
    Member

    J-Son89 commented May 15, 2024

    @BalogunofAfrica - what's the status of this pr?

    Also @ulisesmac recently updated something similar, perhaps it affects this? 🤔

    @ulisesmac
    Copy link
    Contributor

    ulisesmac commented May 15, 2024

    @BalogunofAfrica - what's the status of this pr?

    Also @ulisesmac recently updated something similar, perhaps it affects this? 🤔

    Hi @BalogunofAfrica

    I can see the fix is only focused on changing the blur type, if so then the fix is OK, just wanted to highlight that this header needs more work, it should look almost as the one in the collectibles header:

    Android.-.Light.mov

    But with some differences that match the figma designs

    NOTE: The collectibles header hasn't been merged

    @BalogunofAfrica
    Copy link
    Contributor Author

    BalogunofAfrica commented May 15, 2024

    Hi @Francesca-G this PR would just be to change the blur type.

    I spoke with @ulisesmac and we agreed we might need to rework the community header which would address some of the comments you raised and others not here. As wallets is the maim priority now, this would be descoped and we can take a look after June/July.

    I have created an issue for it here:

    #20049

    cc: @J-Son89

    @Francesca-G Francesca-G moved this from Design review to MERGE in Pipeline for QA May 16, 2024
    @BalogunofAfrica BalogunofAfrica force-pushed the fix/community-header-blur branch 8 times, most recently from e090f8d to 0afba5b Compare May 16, 2024 14:33
    @BalogunofAfrica BalogunofAfrica merged commit c70a2c9 into develop May 16, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE May 16, 2024
    @BalogunofAfrica BalogunofAfrica deleted the fix/community-header-blur branch May 16, 2024 17:29
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Development

    Successfully merging this pull request may close these issues.

    Community top nav blur issue [Android]
    9 participants