You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user is prompted to enter a password during the syncing, the bottom sheet does not seem to properly apply top border radius. This pr address that
Steps to test
Open Status
Navigate to setting screen
Navigate to syncing
Slide to enter your password
Notice the bottom sheet top border radius is not applied
jo-mut
changed the title
fix: apply border radius when on sheet shell background
fix: apply border radius
May 2, 2024
jo-mut
changed the title
fix: apply border radius
fix: apply border radius on authentication bottom sheet during
May 2, 2024
jo-mut
changed the title
fix: apply border radius on authentication bottom sheet during
fix: apply border radius on authentication bottom sheet
May 2, 2024
@ajayesivan@yqrashawn its a simple change to properly apply the radius on the bottom sheet, I thought this does not require manual qa. I added skip-manual-qa label.
Device 2: Find `Button` by `accessibility id`: `image-0`
Device 2: Click system back button
critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
Not expected image is shown to the receiver.
Device 1: Find EditBox by accessibility id: address-text-input
critical/test_wallet.py:123: in test_wallet_send_asset_from_drawer
self.wallet_1.send_asset_from_drawer(address=self.receiver['address'], asset_name='Ether',
../views/wallet_view.py:104: in send_asset_from_drawer
self.address_text_input.send_keys(address)
../views/base_element.py:377: in send_keys
self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
raise NoSuchElementException(
Device 1: EditBox by accessibility id: `address-text-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
Device 2: Text is Sent
critical/chats/test_1_1_public_chats.py:614: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
Message status was not changed to Delivered, it's Sent after back up online!
Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
Device 2: Text is Sent
critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
Message status was not changed to Delivered, it's Sent
# STEP: Change device time so chat will be unmuted by timer
Device 2: Long press on ChatElement
critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
Chat is still muted after timeout
[[Chat is not unmuted after expected time: https://github.com//issues/19627]]
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19662
When the user is prompted to enter a password during the syncing, the bottom sheet does not seem to properly apply top border radius. This pr address that
Steps to test
Before and after screenshots comparison
status: ready