fix_(tests): extract subscriber logic from RPC HealthManager #6147
+278
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require commits to follow the Conventional Commits, but with |
friofry
force-pushed
the
ab/issue-6139-fix-tests
branch
2 times, most recently
from
a5e57ec
to
60964ab
Compare
Jenkins BuildsClick to see older builds (24)
|
igor-sirotin
approved these changes
Nov 29, 2024
| @@ -14,3 +14,4 @@ shell.nix @status-im/devops | |||
| # Feel free to add yourself for any new packages you implement. | |||
| /cmd/status-backend @igor-sirotin | |||
| /internal/sentry @igor-sirotin | |||
| /healthmanager @friofry | |||
* Subscription common logic is extracted to a separate type. * Fix race where go routing extracts value from sync.map and then another go routine calls unsubscribe and closes the channel before the first go routing tries to write to the channel. * moved TestInterleavedChainStatusChanges TestDelayedChainUpdate to the correct file * Renamed test suites with duplicate names updates CODEOWNERS closes #6139
Co-authored-by: Igor Sirotin <[email protected]>
Co-authored-by: Igor Sirotin <[email protected]>
Co-authored-by: Igor Sirotin <[email protected]>
friofry
force-pushed
the
ab/issue-6139-fix-tests
branch
from
4f27821
to
4a91a95
Compare
saledjenic
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6139