Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: TestDelayedChainUpdate #6139

Open
igor-sirotin opened this issue Nov 28, 2024 · 0 comments · May be fixed by #6147
Open

Flaky test: TestDelayedChainUpdate #6139

igor-sirotin opened this issue Nov 28, 2024 · 0 comments · May be fixed by #6147
Assignees
@friofry
Labels
E:Flaky Test

Comments

@igor-sirotin
Copy link
Collaborator 

=== RUN   TestBlockchainHealthManagerSuite/TestDelayedChainUpdate
    blockchain_health_manager_test.go:48: 
        	Error Trace:	/Users/igorsirotin/Repositories/Status/status-go/healthmanager/blockchain_health_manager_test.go:48
        	            				/Users/igorsirotin/Repositories/Status/status-go/healthmanager/blockchain_health_manager_test.go:42
        	            				/Users/igorsirotin/Repositories/Status/status-go/healthmanager/providers_health_manager_test.go:202
        	Error:      	Not equal: 
        	            	expected: "down"
        	            	actual  : "up"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-(rpcstatus.StatusType) (len=4) "down"
        	            	+(rpcstatus.StatusType) (len=2) "up"
        	            	 
        	Test:       	TestBlockchainHealthManagerSuite/TestDelayedChainUpdate
        	Messages:   	Expected blockchain status to be down
--- FAIL: TestBlockchainHealthManagerSuite/TestDelayedChainUpdate (0.00s)
friofry added a commit that referenced this issue Nov 29, 2024
@friofry
fix_(tests): extract subscriber logic from RPC Health Manager
a8c7fb0 
* Subscription common logic is extracted to a separate type.
* Fix race where go routing extracts value from sync.map and then another go routine calls unsubscribe and closes the channel before the first go routing tries to write to the channel.
* moved TestInterleavedChainStatusChanges TestDelayedChainUpdate to the correct file
* Renamed test suites with duplicate names

closes #6139
@friofry friofry linked a pull request Nov 29, 2024 that will close this issue
Open
friofry added a commit that referenced this issue Nov 29, 2024
@friofry
fix_(tests): extract subscriber logic from RPC Health Manager
a5e57ec 
* Subscription common logic is extracted to a separate type.
* Fix race where go routing extracts value from sync.map and then another go routine calls unsubscribe and closes the channel before the first go routing tries to write to the channel.
* moved TestInterleavedChainStatusChanges TestDelayedChainUpdate to the correct file
* Renamed test suites with duplicate names

updates CODEOWNERS
closes #6139
friofry added a commit that referenced this issue Nov 29, 2024
@friofry
fix_(tests): extract subscriber logic from RPC Health Manager
60964ab 
* Subscription common logic is extracted to a separate type.
* Fix race where go routing extracts value from sync.map and then another go routine calls unsubscribe and closes the channel before the first go routing tries to write to the channel.
* moved TestInterleavedChainStatusChanges TestDelayedChainUpdate to the correct file
* Renamed test suites with duplicate names

updates CODEOWNERS
closes #6139
friofry added a commit that referenced this issue Dec 2, 2024
@friofry
fix_(tests): extract subscriber logic from RPC Health Manager
4aa6743 
* Subscription common logic is extracted to a separate type.
* Fix race where go routing extracts value from sync.map and then another go routine calls unsubscribe and closes the channel before the first go routing tries to write to the channel.
* moved TestInterleavedChainStatusChanges TestDelayedChainUpdate to the correct file
* Renamed test suites with duplicate names

updates CODEOWNERS
closes #6139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@friofry friofry

Labels
E:Flaky Test
Projects
Status Desktop/Mobile Board
Status: Next
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix_(tests): extract subscriber logic from RPC HealthManager status-im/status-go
2 participants
@friofry @igor-sirotin