Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: syncing state is broken #147

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christian-bromann
Copy link
Contributor

VSCode Environment

all

Marquee Version

all

Workspace Type

Local Workspace

What happened?

Currently every widget with an ExtensionManager calls:

this._context.globalState.setKeysForSync(Object.keys(this._defaultState))

when it gets initiated. So this happens multiple times for multiple widgets. The problem with that is that it should be called once for all keys that should be synced. Calling it with a different array of keys will replace keys already called by a different widget.

What is your expected behavior?

Collect all keys that are supposed to be synced and call the method then.

Relevant Log Output

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

@christian-bromann christian-bromann added the Bug 🐛 Something isn't working label Jun 22, 2022
@christian-bromann christian-bromann self-assigned this Jun 22, 2022
@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
vscode-marquee ⬜️ Ignored (Inspect) Jun 22, 2022 at 5:11PM (UTC)

@christian-bromann christian-bromann marked this pull request as draft June 22, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant