-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to shopfront-api checkouts, provide agnostic JS and alpine helper #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmitchell
changed the title
Begin move to shopfront-api checkouts, provide agnostic JS and alpine helper
Move to shopfront-api checkouts, provide agnostic JS and alpine helper
Oct 7, 2024
JonKaric
reviewed
Oct 8, 2024
JonKaric
reviewed
Oct 8, 2024
JonKaric
reviewed
Oct 8, 2024
Co-Authored-By: Jon <[email protected]>
Co-Authored-By: Jon <[email protected]>
JonKaric
reviewed
Oct 14, 2024
JonKaric
reviewed
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify are officially deprecating the Buy JS SDK, so we need to move away from it:
Shopify/js-buy-sdk#987
This PR updates the included javascript to provide utility functions for interacting with the GraphQL Storefront Checkout.
It removes most of the existing helper JS. If you have relied on, used, or modified the supplied Javascript then code changes will be required for your site to continue working. Shopify have put an end date of April 2025 on the Buy SDK, so you have until then to update - doing nothing is not an option if you want your site to continue being able to process orders.
In place of the helper JS we are now providing an AlpineJS store() and data(), alongside examples to allow for an easy set up, see the new documentation here: https://github.com/statamic-rad-pack/shopify/blob/feature/move-away-from-buyjs/docs/content/en/frontend/storefront-api.md
You can review the PR on the demo store to see how we managed the changes there: statamic-rad-pack/shopify-demo#1
We are also providing updated JS files for those who want a quick migration, however these should not be seen as a drop in replacement and code changes will still be required.