Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR carries the following updates regarding Python library implementation:
Motivation
Standard webhook specification states that:
The current Python implementation doesn't support the aforementioned statement and exhibits external coupling - two modules share an externally imposed data format.
The significant change is getting rid of returned JSON-encoded payload -- hence removing external coupling
Removing:
Adding:
All unit tests pass.
P.S
Now, the meaning of the word standard makes sense. Otherwise, this library should be renamed to webhookJSONstandard
Live long and pull request!