bump required go version to 1.21 for main module and 1.22 for tools #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTann
force-pushed
the
go-1.21-and-1.22
branch
from
5b4cd39
to
af2a727
Compare
vikin91
reviewed
Sep 16, 2024
| @@ -1,6 +1,6 @@ | |||
| module golang.stackrox.io/grpc-http1 | |||
|
|
|||
| go 1.19 | |||
| go 1.21.0 | |||
There was a problem hiding this comment.
Why freeze this on .0?
Nevermind, this defines the minimum version, so it is all fine.
There was a problem hiding this comment.
yeah exactly. I figured there was no need to define this as go 1.21 and then deal with setting a toolchain version. Figured might as well just stick with go 1.21.0 as the minimum (and implied toolchain version) since this is not meant to be used as the main module
vikin91
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.21 brought go toolchain changes, which makes working with Go versions below 1.21 pretty annoying...
Also, 1.19 is pretty old at this point, so why not bump the minimum required version to 1.21. No need for 1.22 nor 1.23, as there is no reason someone using 1.21 cannot use this.
I bumped tools/go.mod to 1.22, though, due to #215