forward proxy support for client websocket connections #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obno
commented
Dec 28, 2023
obno
commented
- adds forward proxy support to client WS proxy
- adds Dial via HTTP CONNECT tunnel support to TLS ClientHandshake in client side channel credentials
vikin91
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Thank you for your contribution! I looked briefly at the code, but I couldn't see any tests for the feature. Could you please add integration or unit tests?
I am also not fully following which problem this code is solving. Could you please edit the PR description and describe in details which scenarios were not working for you and how this PR fixes the issue?
|
Hi @obno , I wanted to check if you maybe have planned to work further on this PR? |
|
Yes. I will work on this towards the end of this week. Setting up unit tests with a 'squid' like forward proxy is a bit involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.