Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config setting for margin between windows #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

warriordog
Copy link

This PR adds configuration options to specify a gap that will be placed between tiled windows.

The settings "MarginX" and "MarginY" specify the gap (in decimal % of screen size) that will be placed on each side of a window, and the setting "NoMarginAtEdges" determines whether a margin is placed between a window and an edge of the screen (in other words, if this setting is true then windows will stick to the edge of the screen but still have gaps between each other).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 33.147% when pulling d4a7d6d on warriordog:master into 06c4b03 on ssokolow:master.

@ssokolow
Copy link
Owner

ssokolow commented Sep 7, 2018

Thanks for the PR.

I'll look into it, but it won't be immediately, because I have two other things that I need to work on first over the next week or two:

  1. Finish fixing up the last remaining effects of having to ditch legacy Firefox extensions. (I got delayed on this)
  2. Write a basic functional test suite for QuickTile.

(QuickTile has accumulated enough technical debt that my first priority has become a test suite. My plan is to whip up a minimal harness that's similar in concept to Selenium, where it can fire up a copy of Xvfb with a window manager in it, create some mock windows at known positions, then call QuickTile and check that the windows wound up where they were supposed to.)

@warriordog warriordog closed this Aug 3, 2023
@ssokolow
Copy link
Owner

ssokolow commented Aug 3, 2023

Please ask before closing PRs.

I know it's been years, but the societal repercussions of the pandemic left me a bit of a mess in 2019 and it took me years to pick up the pieces to the point where I can get back to my hobby projects... and I do hope to get back to things like this in the near future.

@ssokolow ssokolow reopened this Aug 3, 2023
@ssokolow
Copy link
Owner

ssokolow commented Aug 3, 2023

More specifically, I have an open TODO for making a new release and I have plans to triage through all the open issues and PRs when I do so, adding appropriate information on what got fixed in which commit.

@warriordog
Copy link
Author

@ssokolow You still want it even though its 5 years and 200+ commits out of date?

@ssokolow
Copy link
Owner

ssokolow commented Aug 3, 2023

When I do my triage, I want to compare what you implemented against what I have and extract any implied TODOs or feature requests still not implemented.

@warriordog
Copy link
Author

@ssokolow Gotcha. As long as you don't plan to keep the code - I hacked together that PR without any knowledge of Python so its probably terrible 😆

@ssokolow
Copy link
Owner

ssokolow commented Aug 6, 2023

Yeah, my version doesn't have NoMarginAtEdges, so leaving this open to audit for TODOs was the right decision. I'll close it once I've got something for that committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants