Make $names in attribute public

There were some problems with Symfony var-exporter when using forms. Actual cause is unclear, but setting $names to public fixes the issue and has no other ramifications.
squirrelphp · Dec 20, 2020 · 3a75369 · 3a75369
1 parent de14528
commit 3a75369
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/src/Annotation/StringFilter.php b/src/Annotation/StringFilter.php
@@ -18,7 +18,7 @@ class StringFilter
     /**
      * @var string[] Filter names which should be executed
      */
-    private array $names = [];
+    public array $names = [];
 
     /**
      * @param mixed $names

diff --git a/src/Annotation/StringFilterProcessor.php b/src/Annotation/StringFilterProcessor.php
@@ -61,7 +61,6 @@ public function process(object $class): void
         }
     }
 
-    // @codeCoverageIgnoreStart
     private function getFromAttribute(\ReflectionProperty $property): ?StringFilter
     {
         $attributes = $property->getAttributes(StringFilter::class);
@@ -72,7 +71,6 @@ private function getFromAttribute(\ReflectionProperty $property): ?StringFilter
 
         return $attributes[0]->newInstance();
     }
-    // @codeCoverageIgnoreEnd
 
     private function getFromAnnotation(\ReflectionProperty $property): ?StringFilter
     {

diff --git a/tests/TestClasses/ClassWithPrivateProperties.php b/tests/TestClasses/ClassWithPrivateProperties.php
@@ -9,7 +9,6 @@ class ClassWithPrivateProperties
     /**
      * @StringFilter({"Lowercase","Trim"})
      */
-    #[StringFilter("Lowercase", "Trim")]
     private $title;
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,6 @@ class ClassWithPrivateProperties @@
         /**
          * @StringFilter({"Lowercase","Trim"})
          */
-        #[StringFilter("Lowercase", "Trim")]
         private $title;
         /**
@@ Expand Down @@