CI: Add clang to GitHub Actions build-tests matrix #1812
Conversation
kinkie
changed the title
rousskov
changed the title
Clarify comment on non-testing MacOS/gcc Co-authored-by: Alex Rousskov <[email protected]>
kinkie
force-pushed
the
github-actions-clang
branch
from
f8074b7
to
23258cf
Compare
switch from 'layer' to 'name' remove whitespace use comma instead of slash for separator Co-authored-by: Alex Rousskov <[email protected]>
rousskov
added
the
S-waiting-for-author
If we have to pick one, a "pure gcc" test is more valuable than a "gcc while clang is installed" test.
There was a problem hiding this comment.
I am approving after merging earlier suggestions as discussed during the meeting and polishing PR description a bit. We will need to change the set of the required tests and Anubis configuration to land this PR, but I am requesting @yadij review first.
rousskov
added
S-waiting-for-reviewer
|
I also updated PR description to explain why we now use target environment instead of runner environment in build-tests artifacts name pattern. |
Co-authored-by: Alex Rousskov <[email protected]>
yadij
added
M-cleared-for-merge
Add "compiler" dimension to build-tests matrix. Change build-tests artifacts name pattern to include compiler dimension to avoid name clashes that would result in logs being overwritten and lost. Also use target environment instead of runner environment in anticipation of adding container-based tests where the two differ.
squid-anubis
added
the
M-waiting-staging-checks
|
I have explained layer-04-noauth-everything removal in the PR description. |
|
I have completed items 2 and 3 on the test upgrade plan. This allowed Anubis to stage this PR. @eduard-bagdasaryan, please update Anubis configuration to reflect the current set of required status checks. Doing so will complete item 4. |
rousskov
added
S-waiting-for-QA
Add "compiler" dimension to build-tests matrix. Do not test layer-04-noauth-everything to partially compensate for the new matrix dimension repeating other layer tests 3 times. Change build-tests artifacts name pattern to include compiler dimension to avoid name clashes that would result in logs being overwritten and lost. Also use target environment instead of runner environment in anticipation of adding container-based tests where the two differ.
squid-anubis
added
M-merged
rousskov
removed
the
S-waiting-for-QA
|
I updated that number as the number of tests in 5a7811a. It is 25 now : 12 GitHub tests + 12 Jenkins tests + PR approval. |
|
@eduard-bagdasaryan, thank you. This update leaves only one last step on that upgrade plan: 6: Merge master into other pending PRs as needed. They will not be auto-merged until their branches get new tests (because GitHub testing requirements have changed). There is no reason to rush and update all PRs, of course. We should do that "as needed", usually around the time when a PR is cleared for merging. |
It looks like that one of GitHub tests in 5a7811a is not required: "GitHub CI / CodeQL-tests". I'll fix that parameter to 24. |
|
No objection |
Add "compiler" dimension to build-tests matrix. Do not test layer-04-noauth-everything to partially compensate for the new matrix dimension repeating other layer tests 3 times. Change build-tests artifacts name pattern to include compiler dimension to avoid name clashes that would result in logs being overwritten and lost. Also use target environment instead of runner environment in anticipation of adding container-based tests where the two differ.
Add "compiler" dimension to build-tests matrix.
Do not test layer-04-noauth-everything to partially compensate for the
new matrix dimension repeating other layer tests 3 times.
Change build-tests artifacts name pattern to include compiler dimension
to avoid name clashes that would result in logs being overwritten and
lost. Also use target environment instead of runner environment in
anticipation of adding container-based tests where the two differ.