Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing lints and CI linter timeout #176

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Fixing lints and CI linter timeout #176

merged 3 commits into from
Apr 25, 2023

Conversation

jordyn
Copy link
Collaborator

@jordyn jordyn commented Apr 24, 2023 •
edited

  • Fixing SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
  • Updating golangci-lint 1.51 -> 1.52.2
  • Disabled caching of linting issues due to a bug in the GH action. This shouldn't be an issue going forward as all current lint issues have been addressed: Caching of the linting data causing timeout. golangci/golangci-lint-action#730

@jordyn jordyn requested a review from a team as a code owner April 24, 2023 23:55
@CLAassistant
Copy link

CLAassistant commented Apr 24, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@jordyn jordyn mentioned this pull request Apr 25, 2023
Merged
brettc-sq
brettc-sq approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@brettc-sq brettc-sq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.github/workflows/lint.yaml Show resolved Hide resolved
@jordyn jordyn merged commit 5f20702 into master Apr 25, 2023
2 checks passed
@jordyn jordyn deleted the jordyn-fix-lint-timeouts branch April 25, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettc-sq brettc-sq brettc-sq approved these changes

@suzy-huang suzy-huang Awaiting requested review from suzy-huang suzy-huang is a code owner automatically assigned from square/cryptographic-identity

@bbeirouti bbeirouti Awaiting requested review from bbeirouti bbeirouti is a code owner automatically assigned from square/cryptographic-identity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jordyn @CLAassistant @brettc-sq