Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi-value map #3382

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Add support for multi-value map #3382

wants to merge 3 commits into from

Conversation

zjc17
Copy link

@zjc17 zjc17 commented May 8, 2020

Related Issue: 1324

I've add two test cases and passed for the modification

@zjc17 zjc17 force-pushed the jc-dev branch 2 times, most recently from f7dbf96 to 167aad6 Compare May 8, 2020 15:56
zjc17
zjc17 commented May 30, 2020
View reviewed changes
Copy link
Author

@zjc17 zjc17 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced List with Iterable to make a better solution for multi-value map. Meanwhile, I added a test scenario to achieve 100% test coverage on the modified method. Hope these changes could help somebody.
Related Issue: link

retrofit/src/main/java/retrofit2/ParameterHandler.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctlove0523 ctlove0523 ctlove0523 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zjc17 @ctlove0523