Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockWebServer Named annotations #8210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MockWebServer Named annotations #8210

wants to merge 2 commits into from

Conversation

yschimke
Copy link
Collaborator

@yschimke
MockWebServer Named annotations
2dcced2
@yschimke
Merge branch 'master' into use_named
25c2811 
# Conflicts:
#	mockwebserver-junit5/src/main/kotlin/mockwebserver3/junit5/internal/MockWebServerInstance.kt
swankjesse
swankjesse reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still too complicated.

What about this:

  • each test gets one MockWebServer
  • if you need multiple, just use setUp() and tearDown()

I don’t think using multiple MockWebServer instances is very common!

@yschimke
Copy link
Collaborator Author

Yep, we are probably the only ones using multiple. So it's a feature for ourselves.

That said, I find it elegant because it's no API, no change normally, but available when you need it.

@yschimke
Copy link
Collaborator Author

I'll prepare a separate PR for comparison before closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse swankjesse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yschimke @swankjesse