Handle DnsResolver direct exception on API 34 #8190
Conversation
|
Can't see an easy way to add a test android.net.DnsResolver is final, and no shadow for robolectric. |
yschimke
changed the title
|
Robolectric lets you provide your own shadows if you need one it doesn't provide. Should go into |
|
@JakeWharton care to take another look? I'm keen to fix any noise on github workflows. |
|
I can on Monday |
| } | ||
| }, | ||
| ) | ||
| } catch (e: Exception) { |
There was a problem hiding this comment.
Any idea what kinds of exceptions we’ll be potentially hiding here? We’re attributing an arbitrary failure like an IllegalStateException as an unknown host
There was a problem hiding this comment.
I saw from the attached but report it’s gonna happen when the DNS isn't available.
IllegalArgumentException: Network.fromNetworkHandle refusing to instantiate NETID_UNSET Network.
I agree with this PR, we’ve got to be resilient to this API that doesn’t offer us a ton of good options.
There was a problem hiding this comment.
I'll add a comment.
There was a problem hiding this comment.
Failing on master build https://github.com/square/okhttp/actions/runs/7461208679/job/20300867655
Also seen here Ehviewer-Overhauled/Ehviewer#1311