AttributedLabel Link Accessibility

[RoyalPineapple]

Updating attributed label's links to more closely mirror the SwiftUI accessibility experience

SwiftUI.Link.mp4

This is our current implementation, which doesn't announce links properly.

WithoutLinks.mov

Here is the new version, announcing links as they are read.

WithLinks.mp4

[kyleve]

It looks like there's some failing tests:

Failing tests:

	AttributedLabelTests.test_linkAttribute()
	AttributedLabelTests.test_textContainerRects()

[kyleve]

Do the [ ] have any special meaning here?

[RoyalPineapple]

its really only for the case where the string would be printed. e.g. the accessibility inspector. I wanted to be clear that it's not a part of the displayed text. and that it's explicitly associated with the link string (it doesn't have a preceding space).

I chose the square brackets because

• Voiceover doesn't read the [] characters, but does realize the contained word is distinct from the preceding word.
• They aren't often used in prose, unlike parenthesis. They're unlikely to be confused with the actual content
• They look like markdown.

[kyleve]

Makes sense! It might be good to capture that in a comment inline

[RoyalPineapple]

Replaced with #473

[robmaceachern]

@RoyalPineapple Moving to draft because I think this was addressed elsewhere but feel free to reopen if needed!