Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: range subselect alias pointer dereference #3711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: range subselect alias pointer dereference #3711

wants to merge 1 commit into from

Conversation

ahme-dev
Copy link

@ahme-dev ahme-dev commented Nov 16, 2024 •
edited
Loading

Made to solve dereference panics reported by a list of open issues (I've also seen it in my codebase):

  1. 1.26.0 crashes on subquery without alias #3337
  2. Go panics when sub query is missing an alias with sqlite #3514
  3. sqlc panics on union all with subqueries using mysql #2453

Queries and schemas combined below, none of which panic anymore on this branch.
https://play.sqlc.dev/p/f1541063c62ed9302d43b7d00eec0d487764e5ee577a43e4114ff6c654585768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahme-dev