Fix missing HR in command palette #457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the command palette is built without a prescribed list of commands, the horizontal rule is added to the list of entity types, if it is configured via enableHorizontalRule. If the command palette is built by passing a list of commands, though, enableHorizontalRule is ignored and the HR is not added to the list of entity types. This seems inadvertent and causes the HR to get dropped even if it has been configured. This seems to be the cause of wagtail/wagtail#9707, unless I am misunderstanding how this code is supposed to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the command palette is built without a prescribed list of commands, the horizontal rule is added to the list of entity types, if it is configured via
enableHorizontalRule. If the command palette is built by passing a list of commands, though,enableHorizontalRuleis ignored and the HR is not added to the list of entity types.This seems inadvertent and causes the HR to get dropped even if it has been configured. This seems to be the cause of wagtail/wagtail#9707, unless I am misunderstanding how this code is supposed to work.
The fix in Wagtail's bakerydemo:
(Note: there is likely a DRYer way to implement this without repeating code from above, but my TypeScript skills are pretty basic. Any better suggestions would be appreciated!)