Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working on Grails 3.3.9 #32

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Working on Grails 3.3.9 #32

wants to merge 17 commits into from

Conversation

abcfy2
Copy link

@abcfy2 abcfy2 commented Mar 19, 2019 •
edited
Loading

Thanks to @igoraguiar from #31 . Just fix CI failure.

TODO: Fix deprecated GrailsDomainClass.

bmcguire and others added 17 commits April 3, 2018 12:21
@bmcguire
Removing not needed property in application.yml
4578304
@bmcguire
Updated the dependencies removed ones that are no longer needed.
9881096
@bmcguire
Updated the version of grails and gradle
63ce12e
@bmcguire
Fixed failing test
eec8243
@bmcguire
Fixed the imports for grails 3.3.2
119e7d1
@bmcguire
Fixed imports and added casting based on Grails Core investigation
d7ba269
@bmcguire
Fixed issue with Spring startup and Grails startup. This now delays t…
4de8f25 
…he documentation plugin bootstrap from starting until Grails has started. This resolves the issue with the GORM startup exception
@bmcguire
Update to find the controller method that isn't annotated with grails…
b0413fa 
….web.Action, the method with grails.web.Action is created during AST
@bmcguire
Use the controllers logical property name as is instead of lowercasin…
fd1df4c 
…g it.
@bmcguire
Use Grails classes to do the testing of Controller functions instead …
6df3cac 
…of mocking
Merge remote-tracking branch 'bmcguire/fix-action-method-mapping' int…
a0b53e7 
…o fix-controller-lowercase
Merge branch 'fix-controller-lowercase'
bc40eb1
Fixes SwaggerDocumentationPluginsBootstrapper constructor build error
1ddd096
Fixes GrailsActionContextSpec failing tests
2b10876
Fixes expected service description
b196254 
Since BookController does not extends RestfulController, theses
adjustments were necessary
Fixes path variable name in expected paths
e1bfc9c 
Changes lower case to camel case
@abcfy2
Fix CI failure.
4d70103
@gabivis
Copy link

gabivis commented Sep 30, 2019

Hi. Will this pull request be merged into master?

@thilo-behnke thilo-behnke mentioned this pull request Jul 14, 2020
Open
@thilo-behnke
Copy link

I spent some time testing this fork in a project with grails 3.3.9.

Summary:

  • Configuration / startup of springfox works (springfox + swagger + swagger UI + springfox grails)
  • Swagger endpoints are generated for domain classes and declared REST endpoints (UrlMappings)
  • Swagger UI is generated correctly (correct fields shown) and creates valid requests

Some caveats from my review:

  • I don't use CRUD methods for my project, so I can't say 100% that everything works as expected for domain classes.
  • The deprecation of GrailsDomainClass could cause issues, however I don't have enough knowledge about Grails 2 vs 3 to evaluate the importance of the deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abcfy2 @gabivis @thilo-behnke @bmcguire