Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asAppScopedClient() function for convenience #196

Merged

Conversation

mitchhentgesspotify
Copy link
Contributor

@mitchhentgesspotify mitchhentgesspotify commented Sep 11, 2024

It can be tricky to know which installation ID to provide to withScopeForInstallationId.
Rather than duplicating the "check for an organization installation, then check for a user installation", let's instead move that to this library so it can be reused.

This is a slow operation, but caching of the result can be handled by consumers (if needed) IMO.

@mitchhentgesspotify mitchhentgesspotify marked this pull request as ready for review September 11, 2024 13:39
@Abhi347 Abhi347 merged commit d62279a into spotify:master Sep 12, 2024
3 checks passed
@mitchhentgesspotify mitchhentgesspotify deleted the mhentges/as-app-scoped-client branch September 12, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants