Workspaces Part II #1161
Open
Workspaces Part II #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not yet make use of the versions in any particular way, but exposes the configuration for each template in the workspace API so that it can at least be seen. Signed-off-by: Ryan Bottriell <[email protected]>
Now that workspaces are loaded up-front and hold templates for a reasonable lifetime in the CLI crates, simple references are enough Signed-off-by: Ryan Bottriell <[email protected]>
Versions can be given for each template in the workspace that define which versions can be built from that file. Then, when running commands like 'spk build' we can further disambiguate possible errors by specifying an exact version to build. Signed-off-by: Ryan Bottriell <[email protected]>
This allows a better user experience by only requiring enough of a version number to disambiguate spec files rather than an exact version to build. Signed-off-by: Ryan Bottriell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1160 as part of #1121
Makes use of the versions specified for any given template file by parsing the version from the request and only
findingspec files that are appropriate. Uses theLeastSpecifiedVersionRangeto allow partial versions to be given.As a practical example, the
workspace.spk.yamlfrom this repository lists versions for each python spec, and so you can runspk build python/3to build the default version of the python 3 package spec.