Make Repository object safe #1155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type's implementation was awkwardly split across mod.rs and handle.rs. Signed-off-by: J Robert Ray <[email protected]>
This involves moving the method that has generics into a separate trait, and then by extension traits that needed that method into their own separate traits. Now it is possible to use `dyn Repository` which may become useful. Signed-off-by: J Robert Ray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves moving the method that has generics into a separate trait,
and then by extension traits that needed that method into their own
separate traits.
Now it is possible to use
dyn Repositorywhich may become useful.