This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Support loading subtitles in multiple formats and customizing subtitle tracks #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix a misuse of tracks setter
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@myl7 Please check if my merge commit is the same as your final force push. I am so sorry... |
DogTorrent
force-pushed
the
support-more-subtitles-branch
branch
from
3abd52c
to
3a5c807
Compare
or maybe I can recreate a pr so that you can go through the process all over again? |
|
No problem, this PR seems fine. Since the new feature will add new dependencies and I have not actually fully test it (I am a bit busy in the next few days and can not do it soon), the merging may be late for a time. But it will not be too long. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pull request(#623) was automatically closed because I changed the branch name, and I don't know why, because github said "Open pull requests and draft releases targeting the renamed branch will be retargeted automatically"