Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caret for installing carbon dependency on windows workflow now escaped correctly #336

Merged
merged 1 commit into from
May 21, 2024

Conversation

patrick-cullen
Copy link
Contributor

This solves an issue related to the note in this section of composer docs:
https://getcomposer.org/doc/articles/versions.md#caret-version-range-

Compare the failed Windows job with the successful Ubuntu job here (a package created with this skeleton): https://github.com/patrick-cullen/env-title/actions/runs/9166402787/job/25201714149

Successful Ubuntu job output:

Run composer require "laravel/framework:10.*" "orchestra/testbench:8.*" "nesbot/carbon:^2.63" --no-interaction --no-update
orchestra/testbench is currently present in the require-dev key and you ran the command without the --dev flag, which will move it to the require key.
./composer.json has been updated

Failed Windows job output (note the second line):

Run composer require "laravel/framework:10.*" "orchestra/testbench:8.*" "nesbot/carbon:^2.63" --no-interaction --no-update
The "2.63" constraint for "nesbot/carbon" appears too strict and will likely not match what you want. See https://getcomposer.org/constraints
orchestra/testbench is currently present in the require-dev key and you ran the command without the --dev flag, which will move it to the require key.
./composer.json has been updated

@freekmurze freekmurze merged commit 2b3191e into spatie:main May 21, 2024
1 check passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants